Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add dummy select case #618

Merged
merged 3 commits into from
Nov 22, 2022
Merged

Conversation

waynexia
Copy link
Member

Signed-off-by: Ruihang Xia waynestxia@gmail.com

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

  • fix mode recognization
  • add dummy select cases

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
@waynexia waynexia requested a review from killme2008 November 22, 2022 08:33
Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Merging #618 (42de77e) into develop (b407ebf) will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #618      +/-   ##
===========================================
+ Coverage    86.34%   86.35%   +0.01%     
===========================================
  Files          401      401              
  Lines        50769    50769              
===========================================
+ Hits         43837    43844       +7     
+ Misses        6932     6925       -7     
Flag Coverage Δ
rust 86.35% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/servers/src/opentsdb.rs 98.41% <0.00%> (+1.58%) ⬆️
src/servers/src/error.rs 43.24% <0.00%> (+16.21%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@waynexia waynexia merged commit 9f865b5 into GreptimeTeam:develop Nov 22, 2022
@waynexia waynexia deleted the it-cases branch November 22, 2022 08:47
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants