-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: compaction scheduler and rate limiter #947
feat: compaction scheduler and rate limiter #947
Conversation
bf55aa9
to
d3ab4ec
Compare
d3ab4ec
to
e31ed97
Compare
8fb4210
to
aa9ae7a
Compare
aa9ae7a
to
c64dc9a
Compare
Codecov Report
@@ Coverage Diff @@
## develop #947 +/- ##
===========================================
+ Coverage 85.79% 85.96% +0.17%
===========================================
Files 443 455 +12
Lines 59427 61039 +1612
===========================================
+ Hits 50984 52474 +1490
- Misses 8443 8565 +122
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
1035c07
to
2b2b893
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
25b6661
to
a4fb5ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* wip: compaction schdduler * feat: imple simple compaction scheduler * fix: typo * feat: add generic parameter to make scheduler friendly to tests * chore: add more tests * fix: CR comments * fix: CR comments * fix: ensure idempotency for rate limit token * fix: Cr ct omments
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This is the first part of work towards table compaction which contains:
Picker
) part is still working, but the tests involves the trait so a primitive trait is defined, but it's not the final trait definition.Checklist
Refer to a related PR or issue link (optional)