fix: avoid pushing invalid addr args

[waynexia]

closes #194

The generated command now becomes

 run 'frontend.0' binary '../target/greptimedb-dev/release/greptime' with args: '[--log-level=info frontend start --metasrv-addr=127.0.0.1:3002 -c=../config/frontend.example.toml]', log: '~/.gtctl/mycluster/logs/frontend.0'

without invalid args

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.76%. Comparing base (7861241) to head (cc591fa).

Additional details and impacted files

@@           Coverage Diff            @@
##           develop     #195   +/-   ##
========================================
  Coverage    37.76%   37.76%           
========================================
  Files           16       16           
  Lines         1300     1300           
========================================
  Hits           491      491           
  Misses         704      704           
  Partials       105      105           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[tisonkun]

Perhaps also for generateMetaSrvAddr and generateDatanodeAddr

[waynexia]

The e2e test failure seems unrelated to this change. It's caused by the partition rule change from DB. We shall fix it in a separate PR

[tisonkun]

@waynexia CI failed to your recent PARTITION syntax change - GreptimeTeam/greptimedb#3347

Perhaps you can fix it also?

[tisonkun]

Said now this sql is invalid:

	createTableSQL = `CREATE TABLE dist_table (
                        ts TIMESTAMP DEFAULT current_timestamp(),
                        n INT,
    					row_id INT,
                        TIME INDEX (ts),
                        PRIMARY KEY(n)
                     )
                     PARTITION BY RANGE COLUMNS (n) (
    				 	PARTITION r0 VALUES LESS THAN (5),
    					PARTITION r1 VALUES LESS THAN (9),
    					PARTITION r2 VALUES LESS THAN (MAXVALUE),
					)`

[tisonkun]

Or let's fix the e2e first in another PR first, then we can merge this PR ensuring the tests passed.

[waynexia]

The e2e test failure seems unrelated to this change. It's caused by the partition rule change from DB. We shall fix it in a separate PR

That seems unrelated to this change. Maybe we should pin the db version in the e2e test to also prevent future breaking changes. As those CI are not run in the main repo against every new commit.

[tisonkun]

That seems unrelated to this change. Maybe we should pin the db version in the e2e tes

Make sense. Anyway let's avoid merging patch without CI green if possible. (The failed test is unrelated, but it terminates following tests I guess?)

[waynexia]

The failed test is unrelated, but it terminates following tests I guess?

For this specific case, SQL is run after the cluster is up.

[zyy17]

@waynexia Are you fixing the failure of e2e test? If not, let me fix it in a sperate PR.

[waynexia]

@waynexia Are you fixing the failure of e2e test? If not, let me fix it in a sperate PR.

Trying... #196

[daviderli614]

@waynexia The e2e failure will be fixed in this pr: #197
Can rebase it when merge.