refactor: address review comments

GreptimeTeam · Oct 22, 2024 · f7aed55 · f7aed55
1 parent a85d78c
commit f7aed55
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 6 deletions.
diff --git a/src/parser/ast.rs b/src/parser/ast.rs
@@ -264,19 +264,23 @@ pub enum Offset {
 }
 
 impl Offset {
-    pub fn value_millis(&self) -> i128 {
+    #[cfg(feature = "ser")]
+    pub(crate) fn as_millis(&self) -> i128 {
         match self {
             Self::Pos(dur) => dur.as_millis() as i128,
             Self::Neg(dur) => -(dur.as_millis() as i128),
         }
     }
 
     #[cfg(feature = "ser")]
-    pub fn serialize_offset<S>(offset: &Option<Self>, serializer: S) -> Result<S::Ok, S::Error>
+    pub(crate) fn serialize_offset<S>(
+        offset: &Option<Self>,
+        serializer: S,
+    ) -> Result<S::Ok, S::Error>
     where
         S: serde::Serializer,
     {
-        let value = offset.as_ref().map(|o| o.value_millis()).unwrap_or(0);
+        let value = offset.as_ref().map(|o| o.as_millis()).unwrap_or(0);
         serializer.serialize_i128(value)
     }
 }

diff --git a/src/parser/function.rs b/src/parser/function.rs
@@ -108,7 +108,7 @@ impl Function {
     }
 
     #[cfg(feature = "ser")]
-    pub fn serialize_variadic<S>(variadic: &bool, serializer: S) -> Result<S::Ok, S::Error>
+    pub(crate) fn serialize_variadic<S>(variadic: &bool, serializer: S) -> Result<S::Ok, S::Error>
     where
         S: serde::Serializer,
     {

diff --git a/src/util/duration.rs b/src/util/duration.rs
@@ -136,7 +136,7 @@ pub fn display_duration(duration: &Duration) -> String {
 }
 
 #[cfg(feature = "ser")]
-pub fn serialize_duration<S>(dur: &Duration, serializer: S) -> Result<S::Ok, S::Error>
+pub(crate) fn serialize_duration<S>(dur: &Duration, serializer: S) -> Result<S::Ok, S::Error>
 where
     S: serde::Serializer,
 {
@@ -145,7 +145,10 @@ where
 }
 
 #[cfg(feature = "ser")]
-pub fn serialize_duration_opt<S>(dur: &Option<Duration>, serializer: S) -> Result<S::Ok, S::Error>
+pub(crate) fn serialize_duration_opt<S>(
+    dur: &Option<Duration>,
+    serializer: S,
+) -> Result<S::Ok, S::Error>
 where
     S: serde::Serializer,
 {