fix(deps): @ethereumjs/tx@4.1.1->^4.1.2 #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
github-merge-queue bot
pushed a commit
to MetaMask/metamask-extension
that referenced
this pull request
Oct 22, 2024
## **Description**
- fix(deps): `gridplus-sdk@2.5.1->~2.6.0`
- `2.7.0` updates to `@ethereumjs/tx` 5, so holding at 2.6
- removes dependency on legacy `ethereum-cryptography` v1
- dedupe and unpin `@ethereumjs/tx` to `^4.2.0`
- `eth-lattice-keyring` is pinned to `@ethereumjs/tx@4.1.1`
- `gridplus-sdk` is pinned to `@ethereumjs/tx@4.1.2`
- fix(deps): bump `elliptic@6.5.4->^6.5.7` via resolutions
- fix(deps): bump `secp256k`
[](https://codespaces.new/MetaMask/metamask-extension/pull/27973?quickstart=1)
## **Related issues**
- GridPlus/eth-lattice-keyring#64
- GridPlus/gridplus-sdk#547
## **Manual testing steps**
## **Screenshots/Recordings**
### **Before**
### **After**
## **Pre-merge author checklist**
- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
## **Pre-merge reviewer checklist**
- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
hjetpoluru
pushed a commit
to MetaMask/metamask-extension
that referenced
this pull request
Oct 28, 2024
## **Description**
- fix(deps): `gridplus-sdk@2.5.1->~2.6.0`
- `2.7.0` updates to `@ethereumjs/tx` 5, so holding at 2.6
- removes dependency on legacy `ethereum-cryptography` v1
- dedupe and unpin `@ethereumjs/tx` to `^4.2.0`
- `eth-lattice-keyring` is pinned to `@ethereumjs/tx@4.1.1`
- `gridplus-sdk` is pinned to `@ethereumjs/tx@4.1.2`
- fix(deps): bump `elliptic@6.5.4->^6.5.7` via resolutions
- fix(deps): bump `secp256k`
[](https://codespaces.new/MetaMask/metamask-extension/pull/27973?quickstart=1)
## **Related issues**
- GridPlus/eth-lattice-keyring#64
- GridPlus/gridplus-sdk#547
## **Manual testing steps**
## **Screenshots/Recordings**
### **Before**
### **After**
## **Pre-merge author checklist**
- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
## **Pre-merge reviewer checklist**
- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Closed
14 tasks
danjm
pushed a commit
to MetaMask/metamask-extension
that referenced
this pull request
Oct 29, 2024
](https://codespaces.new/MetaMask/metamask-extension/pull/27973?quickstart=1){kind=link}
- fix(deps): `gridplus-sdk@2.5.1->~2.6.0`
- `2.7.0` updates to `@ethereumjs/tx` 5, so holding at 2.6
- removes dependency on legacy `ethereum-cryptography` v1
- dedupe and unpin `@ethereumjs/tx` to `^4.2.0`
- `eth-lattice-keyring` is pinned to `@ethereumjs/tx@4.1.1`
- `gridplus-sdk` is pinned to `@ethereumjs/tx@4.1.2`
- fix(deps): bump `elliptic@6.5.4->^6.5.7` via resolutions
- fix(deps): bump `secp256k`
[](https://codespaces.new/MetaMask/metamask-extension/pull/27973?quickstart=1)
- GridPlus/eth-lattice-keyring#64
- GridPlus/gridplus-sdk#547
- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
danjm
pushed a commit
to MetaMask/metamask-extension
that referenced
this pull request
Oct 29, 2024
- fix(deps): `gridplus-sdk@2.5.1->~2.6.0`
- `2.7.0` updates to `@ethereumjs/tx` 5, so holding at 2.6
- removes dependency on legacy `ethereum-cryptography` v1
- dedupe and unpin `@ethereumjs/tx` to `^4.2.0`
- `eth-lattice-keyring` is pinned to `@ethereumjs/tx@4.1.1`
- `gridplus-sdk` is pinned to `@ethereumjs/tx@4.1.2`
- fix(deps): bump `elliptic@6.5.4->^6.5.7` via resolutions
- fix(deps): bump `secp256k`
[](https://codespaces.new/MetaMask/metamask-extension/pull/27973?quickstart=1)
- GridPlus/eth-lattice-keyring#64
- GridPlus/gridplus-sdk#547
- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependency
@ethereumjs/txis pinned to legacy4.1.1. This unpins it to^4.1.2(which includes latest 4.x,4.2.0).Related