v1.3.0 #386
Merged
v1.3.0 #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cs under API heading
Updates KV tests to work with new signing path
Adds dotenv supprt and test tasks
With the legacy path, requesters expect a `v` value returned when making an EVM signature. This was possible with the exported `getV` util but this was not integrated into the signing pathway and it had some shortcomings (i.e. input had to be an @ethereumjs/tx obect), so it has now been spliced into the main signing pathway. NOTE: `v` is a `Buffer` type as with the legacy signing path, but we should move away from this and into a more standard `bn.js` number type in a future major version bump
Adds `v` component to `EVM` signing requests for backwards compatability
alex-miller-0
approved these changes
May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
vcomponent toEVMsigning requests for backwards compatability #385) Adds v component to EVM signing requests for backwards compatibilityMisc: