updates docs to refer to functional API #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrcnk
approved these changes
May 24, 2024
| name: 'My Wallet', | ||
| deviceId: 'XXXXXX', | ||
| password: 'password', | ||
| getStoredClient: () => localStorage.getItem('client'), |
There was a problem hiding this comment.
Would be great to also cover async storages since most of the browser extension integrations will require it. If the fix to allow async storages was added to the SDK already, we just probably need to mention it should work fine, if not, then maybe point to the workaround with Zustand I did in Rainbow.
There was a problem hiding this comment.
async storage will come in the next major release. we're pushing this out before that.
netbonus
force-pushed
the
nb/func-docs
branch
2 times, most recently
from
9586c6b
to
b1176cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.