Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GT_ASSUME for NVCC and Enable GT_ASSUME on Recent GCC Versions #1789

Merged
merged 9 commits into from
Jul 8, 2024

Conversation

fthaler
Copy link
Contributor

@fthaler fthaler commented Jun 19, 2024

  • Fixes non-functional GT_ASSUME on NVCC due to __has_builtin(__builtin_assume) returning 0.
  • Adds a test to check correctly defined device-side GT_ASSUME on NVCC.
  • Enables GT_ASSUME based on C++-23 [[assume(x)]] on recent versions of GCC.

@gridtoolsjenkins
Copy link
Collaborator

Hi there, this is jenkins continuous integration...
Do you want me to verify this patch?

@havogt
Copy link
Contributor

havogt commented Jun 20, 2024

launch jenkins

@havogt
Copy link
Contributor

havogt commented Jun 20, 2024

launch perftests

@fthaler fthaler marked this pull request as ready for review June 24, 2024 05:52
@fthaler
Copy link
Contributor Author

fthaler commented Jun 24, 2024

launch jenkins

1 similar comment
@havogt
Copy link
Contributor

havogt commented Jun 24, 2024

launch jenkins

@fthaler
Copy link
Contributor Author

fthaler commented Jun 24, 2024

launch jenkins

@fthaler
Copy link
Contributor Author

fthaler commented Jun 24, 2024

launch perftest

@havogt
Copy link
Contributor

havogt commented Jun 25, 2024

launch jenkins

@fthaler fthaler changed the title Enable GT_ASSUME on Recent GCC Versions Fix GT_ASSUME for NVCC and Enable GT_ASSUME on Recent GCC Versions Jun 26, 2024
@fthaler
Copy link
Contributor Author

fthaler commented Jun 26, 2024

launch jenkins

@fthaler
Copy link
Contributor Author

fthaler commented Jun 26, 2024

launch perftest

@fthaler fthaler requested a review from havogt June 26, 2024 08:23
@fthaler
Copy link
Contributor Author

fthaler commented Jun 26, 2024

launch jenkins

@fthaler
Copy link
Contributor Author

fthaler commented Jul 8, 2024

launch jenkins

@fthaler
Copy link
Contributor Author

fthaler commented Jul 8, 2024

launch perftest

@fthaler
Copy link
Contributor Author

fthaler commented Jul 8, 2024

Everything seems to work now apart from ault which is still offline.

@fthaler fthaler requested a review from havogt July 8, 2024 09:34
@fthaler fthaler requested a review from iomaganaris July 8, 2024 09:34
Copy link
Contributor

@iomaganaris iomaganaris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Tested this with nvcc and clang and it works as expected

@fthaler fthaler merged commit 3d5f405 into GridTools:master Jul 8, 2024
67 of 68 checks passed
@fthaler fthaler deleted the more-assume branch July 8, 2024 11:46
havogt pushed a commit that referenced this pull request Sep 30, 2024
…1789)

- Fixes non-functional `GT_ASSUME` on NVCC due to `__has_builtin(__builtin_assume)` returning 0.
- Adds a test to check correctly defined device-side `GT_ASSUME` on NVCC.
- Enables `GT_ASSUME` based on C++-23 `[[assume(x)]]` on recent versions of GCC.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants