Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat[next][dace]: keep transients on the output of a mapped nested SDFG #1828

Merged
merged 3 commits into from
Jan 30, 2025

Conversation

edopao
Copy link
Contributor

@edopao edopao commented Jan 28, 2025

Small change to the lowering from GTIR, that keeps a transient buffer on the output of a nested SDFG, before the write memlet through the MapExit node. Removal of the transient, which was the baseline behavior, prevents map fusion in the optimization workflow.

Copy link
Contributor

@philip-paul-mueller philip-paul-mueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@philip-paul-mueller philip-paul-mueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edopao edopao merged commit 5752f2b into GridTools:main Jan 30, 2025
21 checks passed
@edopao edopao deleted the gtir-dace-transient_mapped_nsdfg branch January 30, 2025 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants