Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new feat] implemnent gr#import #548

Merged
merged 2 commits into from
Jan 4, 2018
Merged

[new feat] implemnent gr#import #548

merged 2 commits into from
Jan 4, 2018

Conversation

moajo
Copy link
Contributor

@moajo moajo commented Dec 28, 2017

gr#import is an alternative to gr.lib.

You can reference modules in the same path as typescript import.

let MaterialContainer =  gr.import("grimoirejs-fundamental/ref/Components/MaterialContainer");
let GomlNode = gr.import("grimoirejs/ref/Core/Node");

if plugin is not found, an error will occur.
if plugin is found but module is not found, a different error will occur.

@moajo moajo requested a review from kyasbal December 28, 2017 05:13
@moajo moajo changed the title feat: implemnent gr#import [new feat] implemnent gr#import Dec 28, 2017
Copy link
Member

@kyasbal kyasbal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@moajo moajo merged commit 51b0035 into develop Jan 4, 2018
@moajo moajo deleted the feat/grimport branch January 4, 2018 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants