Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[new feat] Plugin assertion #549

Merged
merged 3 commits into from
Jan 4, 2018
Merged

[new feat] Plugin assertion #549

merged 3 commits into from
Jan 4, 2018

Conversation

moajo
Copy link
Contributor

@moajo moajo commented Dec 28, 2017

dynamic assertion that a plugin is registerd.

gr.assertPlugin("fundamental");
gr.assertPlugin("notfound"); // Error: required plugin 'notfound' is not registered.
gr.assertPlugin("notfound", "You can change the error message"); // Error: You can change the error message

@moajo moajo requested a review from kyasbal December 28, 2017 05:12
@moajo moajo changed the base branch from master to develop December 28, 2017 05:12
@moajo moajo merged commit a269e2f into develop Jan 4, 2018
@moajo moajo deleted the feat/plugin-assert branch January 4, 2018 05:47
@kyasbal
Copy link
Member

kyasbal commented Jan 4, 2018

Grimoire.js E2E Test result

** Commit: f9ae310**

Compared with 56fd1ce

This page or pull request reply was automatically generated.

Summary

Diff changed E2E result count : 17 / 17

forward-shading

Test results: 1

0:forward-shading/pbr-rougness-metallic[NOT TESTED BEFORE]

  • load: FAIL
  • waitFor: FAIL

OPEN

Logs 
log:%cGrimoire.js v1.0.0
plugins:

  1 : grimoirejs-math@1.15.1

To suppress this message,please inject a line "gr.debug = false;" on the initializing timing. color:#44F;font-weight:bold;
error:JSHandle@error
Meta
Key Value
config [object Object]
loadTime FAIL
initializingTime FAIL
logs [object Object],[object Object]
diffTestResult false
url http://jsrun.it/kyasbal/gCfn3#grimoirejs=staging-f9ae31043083789340fb36bebf20ac41585825d0
Config
Key Value
url http://jsrun.it/kyasbal/gCfn3
timeout 100000
waitFor
width 640
height 480
threshold 3%
shift 2
group forward-shading
name pbr-rougness-metallic

fundamental

Test results: 9

0:fundamental/texture-direction[NOT TESTED BEFORE]

  • load: FAIL
  • waitFor: FAIL

OPEN

Logs 
log:%cGrimoire.js v1.0.0
plugins:

  1 : grimoirejs-math@1.15.1

To suppress this message,please inject a line "gr.debug = false;" on the initializing timing. color:#44F;font-weight:bold;
error:JSHandle@error
Meta
Key Value
config [object Object]
loadTime FAIL
initializingTime FAIL
logs [object Object],[object Object]
diffTestResult false
url https://codepen.io/kyasbal-1994/debug/gXMBJV#grimoirejs=staging-f9ae31043083789340fb36bebf20ac41585825d0
Config
Key Value
url https://codepen.io/kyasbal-1994/debug/gXMBJV
timeout 100000
waitFor
width 640
height 480
threshold 3%
shift 2
group fundamental
name texture-direction

1:fundamental/uv[NOT TESTED BEFORE]

  • load: FAIL
  • waitFor: FAIL

OPEN

Logs 
log:%cGrimoire.js v1.0.0
plugins:

  1 : grimoirejs-math@1.15.1

To suppress this message,please inject a line "gr.debug = false;" on the initializing timing. color:#44F;font-weight:bold;
error:JSHandle@error
Meta
Key Value
config [object Object]
loadTime FAIL
initializingTime FAIL
logs [object Object],[object Object]
diffTestResult false
url https://codepen.io/kyasbal-1994/debug/vWXLLK#grimoirejs=staging-f9ae31043083789340fb36bebf20ac41585825d0
Config
Key Value
url https://codepen.io/kyasbal-1994/debug/vWXLLK
timeout 100000
waitFor
width 640
height 480
threshold 3%
shift 2
group fundamental
name uv

2:fundamental/normal[NOT TESTED BEFORE]

  • load: FAIL
  • waitFor: FAIL

OPEN

Logs 
log:%cGrimoire.js v1.0.0
plugins:

  1 : grimoirejs-math@1.15.1

To suppress this message,please inject a line "gr.debug = false;" on the initializing timing. color:#44F;font-weight:bold;
error:JSHandle@error
Meta
Key Value
config [object Object]
loadTime FAIL
initializingTime FAIL
logs [object Object],[object Object]
diffTestResult false
url https://codepen.io/kyasbal-1994/debug/RjGroo#grimoirejs=staging-f9ae31043083789340fb36bebf20ac41585825d0
Config
Key Value
url https://codepen.io/kyasbal-1994/debug/RjGroo
timeout 100000
waitFor
width 640
height 480
threshold 3%
shift 2
group fundamental
name normal

3:fundamental/wireframe[NOT TESTED BEFORE]

  • load: FAIL
  • waitFor: FAIL

OPEN

Logs 
log:%cGrimoire.js v1.0.0
plugins:

  1 : grimoirejs-math@1.15.1

To suppress this message,please inject a line "gr.debug = false;" on the initializing timing. color:#44F;font-weight:bold;
error:JSHandle@error
Meta
Key Value
config [object Object]
loadTime FAIL
initializingTime FAIL
logs [object Object],[object Object]
diffTestResult false
url https://codepen.io/kyasbal-1994/debug/MOmjyJ#grimoirejs=staging-f9ae31043083789340fb36bebf20ac41585825d0
Config
Key Value
url https://codepen.io/kyasbal-1994/debug/MOmjyJ
timeout 100000
waitFor
width 640
height 480
threshold 3%
shift 2
group fundamental
name wireframe

4:fundamental/canvasFollowRelative[NOT TESTED BEFORE]

  • load: FAIL
  • waitFor: FAIL

OPEN

Logs 
log:%cGrimoire.js v1.0.0
plugins:

  1 : grimoirejs-math@1.15.1

To suppress this message,please inject a line "gr.debug = false;" on the initializing timing. color:#44F;font-weight:bold;
error:JSHandle@error
Meta
Key Value
config [object Object]
loadTime FAIL
initializingTime FAIL
logs [object Object],[object Object]
diffTestResult false
url https://codepen.io/kyasbal-1994/debug/bf323f6b9725ceb75f0865d6dddd68b9#grimoirejs=staging-f9ae31043083789340fb36bebf20ac41585825d0
Config
Key Value
url https://codepen.io/kyasbal-1994/debug/bf323f6b9725ceb75f0865d6dddd68b9
timeout 100000
waitFor
width 640
height 480
threshold 3%
shift 2
group fundamental
name canvasFollowRelative

5:fundamental/canvasConsiderBorder[NOT TESTED BEFORE]

  • load: FAIL
  • waitFor: FAIL

OPEN

Logs 
log:%cGrimoire.js v1.0.0
plugins:

  1 : grimoirejs-math@1.15.1

To suppress this message,please inject a line "gr.debug = false;" on the initializing timing. color:#44F;font-weight:bold;
error:JSHandle@error
Meta
Key Value
config [object Object]
loadTime FAIL
initializingTime FAIL
logs [object Object],[object Object]
diffTestResult false
url https://codepen.io/kyasbal-1994/debug/d448653295e3678bdbbc626bf9192f79#grimoirejs=staging-f9ae31043083789340fb36bebf20ac41585825d0
Config
Key Value
url https://codepen.io/kyasbal-1994/debug/d448653295e3678bdbbc626bf9192f79
timeout 100000
waitFor
width 640
height 480
threshold 3%
shift 2
group fundamental
name canvasConsiderBorder

6:fundamental/dynamicParentSizeChange[NOT TESTED BEFORE]

  • load: FAIL
  • waitFor: FAIL

OPEN

Logs 
log:%cGrimoire.js v1.0.0
plugins:

  1 : grimoirejs-math@1.15.1

To suppress this message,please inject a line "gr.debug = false;" on the initializing timing. color:#44F;font-weight:bold;
error:JSHandle@error
Meta
Key Value
config [object Object]
loadTime FAIL
initializingTime FAIL
logs [object Object],[object Object]
diffTestResult false
url https://codepen.io/kyasbal-1994/debug/074bef092e7a50ed3e33fe7c75c923e6#grimoirejs=staging-f9ae31043083789340fb36bebf20ac41585825d0
Config
Key Value
url https://codepen.io/kyasbal-1994/debug/074bef092e7a50ed3e33fe7c75c923e6
timeout 100000
waitFor
width 640
height 480
threshold 3%
shift 2
group fundamental
name dynamicParentSizeChange

7:fundamental/drawerContext[NOT TESTED BEFORE]

  • load: FAIL
  • waitFor: FAIL

OPEN

Logs 
log:%cGrimoire.js v1.0.0
plugins:

  1 : grimoirejs-math@1.15.1

To suppress this message,please inject a line "gr.debug = false;" on the initializing timing. color:#44F;font-weight:bold;
error:JSHandle@error
Meta
Key Value
config [object Object]
loadTime FAIL
initializingTime FAIL
logs [object Object],[object Object]
diffTestResult false
url https://codepen.io/kyasbal-1994/debug/b26f4b576f96d077eb0aab1d6b88668f#grimoirejs=staging-f9ae31043083789340fb36bebf20ac41585825d0
Config
Key Value
url https://codepen.io/kyasbal-1994/debug/b26f4b576f96d077eb0aab1d6b88668f
timeout 100000
waitFor
width 640
height 480
threshold 3%
shift 2
group fundamental
name drawerContext

8:fundamental/drawerContext2[NOT TESTED BEFORE]

  • load: FAIL
  • waitFor: FAIL

OPEN

Logs 
log:%cGrimoire.js v1.0.0
plugins:

  1 : grimoirejs-math@1.15.1

To suppress this message,please inject a line "gr.debug = false;" on the initializing timing. color:#44F;font-weight:bold;
error:JSHandle@error
Meta
Key Value
config [object Object]
loadTime FAIL
initializingTime FAIL
logs [object Object],[object Object]
diffTestResult false
url https://s.codepen.io/kyasbal-1994/debug/c0e1065f3c412d326859c69fc4befb52#grimoirejs=staging-f9ae31043083789340fb36bebf20ac41585825d0
Config
Key Value
url https://s.codepen.io/kyasbal-1994/debug/c0e1065f3c412d326859c69fc4befb52
timeout 100000
waitFor
width 640
height 480
threshold 3%
shift 2
group fundamental
name drawerContext2

glTF

Test results: 7

0:glTF/gltf-triangle[NOT TESTED BEFORE]

  • load: FAIL
  • waitFor: FAIL

OPEN

Logs 
log:%cGrimoire.js v1.0.0
plugins:

  1 : grimoirejs-math@1.15.1

To suppress this message,please inject a line "gr.debug = false;" on the initializing timing. color:#44F;font-weight:bold;
error:JSHandle@error
Meta
Key Value
config [object Object]
loadTime FAIL
initializingTime FAIL
logs [object Object],[object Object]
diffTestResult false
url https://codepen.io/kyasbal-1994/debug/e8ca361b9c48e123380f391d31210de5#grimoirejs=staging-f9ae31043083789340fb36bebf20ac41585825d0
Config
Key Value
url https://codepen.io/kyasbal-1994/debug/e8ca361b9c48e123380f391d31210de5
timeout 100000
waitFor
width 640
height 480
threshold 3%
shift 2
group glTF
name gltf-triangle

1:glTF/gltf-triangle-without-indices[NOT TESTED BEFORE]

  • load: FAIL
  • waitFor: FAIL

OPEN

Logs 
log:%cGrimoire.js v1.0.0
plugins:

  1 : grimoirejs-math@1.15.1

To suppress this message,please inject a line "gr.debug = false;" on the initializing timing. color:#44F;font-weight:bold;
error:JSHandle@error
Meta
Key Value
config [object Object]
loadTime FAIL
initializingTime FAIL
logs [object Object],[object Object]
diffTestResult false
url https://codepen.io/kyasbal-1994/debug/b5b1bc440f20c52166aeefd01cbb677e#grimoirejs=staging-f9ae31043083789340fb36bebf20ac41585825d0
Config
Key Value
url https://codepen.io/kyasbal-1994/debug/b5b1bc440f20c52166aeefd01cbb677e
timeout 100000
waitFor
width 640
height 480
threshold 3%
shift 2
group glTF
name gltf-triangle-without-indices

2:glTF/gltf-simple-meshes[NOT TESTED BEFORE]

  • load: FAIL
  • waitFor: FAIL

OPEN

Logs 
log:%cGrimoire.js v1.0.0
plugins:

  1 : grimoirejs-math@1.15.1

To suppress this message,please inject a line "gr.debug = false;" on the initializing timing. color:#44F;font-weight:bold;
error:JSHandle@error
Meta
Key Value
config [object Object]
loadTime FAIL
initializingTime FAIL
logs [object Object],[object Object]
diffTestResult false
url https://codepen.io/kyasbal-1994/debug/6e959821e1870e44d75bb9eb5b76ad14#grimoirejs=staging-f9ae31043083789340fb36bebf20ac41585825d0
Config
Key Value
url https://codepen.io/kyasbal-1994/debug/6e959821e1870e44d75bb9eb5b76ad14
timeout 100000
waitFor
width 640
height 480
threshold 3%
shift 2
group glTF
name gltf-simple-meshes

3:glTF/gltf-suzane[NOT TESTED BEFORE]

  • load: FAIL
  • waitFor: FAIL

OPEN

Logs 
log:%cGrimoire.js v1.0.0
plugins:

  1 : grimoirejs-math@1.15.1

To suppress this message,please inject a line "gr.debug = false;" on the initializing timing. color:#44F;font-weight:bold;
error:JSHandle@error
Meta
Key Value
config [object Object]
loadTime FAIL
initializingTime FAIL
logs [object Object],[object Object]
diffTestResult false
url https://s.codepen.io/kyasbal-1994/debug/fac20bbbeb4713f2a2169b09f615b741#grimoirejs=staging-f9ae31043083789340fb36bebf20ac41585825d0
Config
Key Value
url https://s.codepen.io/kyasbal-1994/debug/fac20bbbeb4713f2a2169b09f615b741
timeout 100000
waitFor
width 640
height 480
threshold 3%
shift 2
group glTF
name gltf-suzane

4:glTF/gltf-duck[NOT TESTED BEFORE]

  • load: FAIL
  • waitFor: FAIL

OPEN

Logs 
log:%cGrimoire.js v1.0.0
plugins:

  1 : grimoirejs-math@1.15.1

To suppress this message,please inject a line "gr.debug = false;" on the initializing timing. color:#44F;font-weight:bold;
error:JSHandle@error
Meta
Key Value
config [object Object]
loadTime FAIL
initializingTime FAIL
logs [object Object],[object Object]
diffTestResult false
url https://s.codepen.io/kyasbal-1994/debug/a600e4dd689e739ba59ff8e01b69e92e#grimoirejs=staging-f9ae31043083789340fb36bebf20ac41585825d0
Config
Key Value
url https://s.codepen.io/kyasbal-1994/debug/a600e4dd689e739ba59ff8e01b69e92e
timeout 100000
waitFor
width 640
height 480
threshold 3%
shift 2
group glTF
name gltf-duck

5:glTF/gltf-embedded-simple-meshes[NOT TESTED BEFORE]

  • load: FAIL
  • waitFor: FAIL

OPEN

Logs 
log:%cGrimoire.js v1.0.0
plugins:

  1 : grimoirejs-math@1.15.1

To suppress this message,please inject a line "gr.debug = false;" on the initializing timing. color:#44F;font-weight:bold;
error:JSHandle@error
Meta
Key Value
config [object Object]
loadTime FAIL
initializingTime FAIL
logs [object Object],[object Object]
diffTestResult false
url https://codepen.io/kyasbal-1994/debug/afa9b0bc42997cb884682dfaafd3529d#grimoirejs=staging-f9ae31043083789340fb36bebf20ac41585825d0
Config
Key Value
url https://codepen.io/kyasbal-1994/debug/afa9b0bc42997cb884682dfaafd3529d
timeout 100000
waitFor
width 640
height 480
threshold 3%
shift 2
group glTF
name gltf-embedded-simple-meshes

6:glTF/gltf-embedded-duck[NOT TESTED BEFORE]

  • load: FAIL
  • waitFor: FAIL

OPEN

Logs 
log:%cGrimoire.js v1.0.0
plugins:

  1 : grimoirejs-math@1.15.1

To suppress this message,please inject a line "gr.debug = false;" on the initializing timing. color:#44F;font-weight:bold;
error:JSHandle@error
Meta
Key Value
config [object Object]
loadTime FAIL
initializingTime FAIL
logs [object Object],[object Object]
diffTestResult false
url https://codepen.io/kyasbal-1994/debug/079bead3a79fe8a059a41ae552b820bd#grimoirejs=staging-f9ae31043083789340fb36bebf20ac41585825d0
Config
Key Value
url https://codepen.io/kyasbal-1994/debug/079bead3a79fe8a059a41ae552b820bd
timeout 100000
waitFor
width 640
height 480
threshold 3%
shift 2
group glTF
name gltf-embedded-duck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyasbal kyasbal kyasbal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@moajo @kyasbal