Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pages/routing #34

Closed
1 task
atherdon opened this issue Jun 24, 2018 · 5 comments
Closed
1 task

pages/routing #34

atherdon opened this issue Jun 24, 2018 · 5 comments
Assignees
@sanchit94
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@atherdon
Copy link
Member

atherdon commented Jun 24, 2018 •
edited
Loading

https://github.com/facebook/create-react-app/blob/master/packages/react-scripts/template/README.md#adding-a-router

  • Separate your page into 2 pages
    Use router for this
    Index page will be for our code from chapters(forms, our calendar, etc)
    page with URL /calendar - will display our designed calendar
@atherdon atherdon added enhancement New feature or request good first issue Good for newcomers labels Jun 24, 2018
@sanchit94
Copy link
Collaborator

@atherdon No idea about routing, could you suggest something I can refer for studying this?

@atherdon
Copy link
Member Author

atherdon commented Jun 27, 2018 via email •
edited
Loading

@atherdon
Copy link
Member Author

#47

@atherdon
Copy link
Member Author

sample: https://github.com/ChickenKyiv/react-menu-monkey-client/blob/master/src/routes/index.js

sanchit94 added a commit that referenced this issue Jun 30, 2018
@sanchit94
Added routers and fixed warning messages
7ff6e5c 
Fixes #34 and #48 , and partially #39
sanchit94 added a commit that referenced this issue Jun 30, 2018
@sanchit94
# This is a combination of 3 commits.
e88b90a 
# This is the 1st commit message:

small changes, to organise the code.

# This is the commit message #2:

Removed unused files

# This is the commit message #3:

Added routers and fixed warning messages

Fixes #34 and #48 , and partially #39
sanchit94 added a commit that referenced this issue Jun 30, 2018
@sanchit94
Stashed Commit
2c1a2c9 
small changes, to organise the code.

Removed unused files

Added routers and fixed warning messages

Fixes #34 and #48 , and partially #39

upd

upd

upd

Fixed minor bugs
@atherdon
Copy link
Member Author

atherdon commented Jul 1, 2018

ok, closing this

@atherdon atherdon closed this as completed Jul 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sanchit94 sanchit94

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@atherdon @sanchit94