Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timeline component #40

Closed
atherdon opened this issue Jun 29, 2018 · 2 comments
Closed

Timeline component #40

atherdon opened this issue Jun 29, 2018 · 2 comments
Assignees
@sanchit94
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@atherdon
Copy link
Member

atherdon commented Jun 29, 2018 •
edited
Loading

Maybe we should move it into a separated file?

<ListGroupItem>9:00</ListGroupItem>
                        <ListGroupItem>10:00</ListGroupItem>
                        <ListGroupItem>11:00</ListGroupItem>
                        <ListGroupItem>12:00</ListGroupItem>
                        <ListGroupItem>13:00</ListGroupItem>
                        <ListGroupItem>14:00</ListGroupItem>
                        <ListGroupItem>15:00</ListGroupItem>
                        <ListGroupItem>16:00</ListGroupItem>
                        <ListGroupItem>17:00</ListGroupItem>
                        <ListGroupItem>18:00</ListGroupItem>

2 things: 1 please update it
and keep in mind.
let's assume we have 2 options, 24h time && 12h time - make it work for both cases
@atherdon atherdon added enhancement New feature or request help wanted Extra attention is needed labels Jun 29, 2018
@atherdon
Copy link
Member Author

#47

sanchit94 added a commit that referenced this issue Jul 1, 2018
@sanchit94
Feature added- 24 hrs and 12 hrs mode. Fixes #46 and #40
77d7c73
@sanchit94
Copy link
Collaborator

Maybe we should close this one now?

@atherdon atherdon closed this as completed Jul 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sanchit94 sanchit94

Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@atherdon @sanchit94