Adding Styler + PNM format improvement #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warmwaffles
reviewed
Jun 10, 2024
| @@ -35,7 +35,8 @@ defmodule ExImageInfo.Mixfile do | |||
| {:excoveralls, "~> 0.18", only: :test}, | |||
| {:ex_doc, "~> 0.30", only: :dev}, | |||
| {:inch_ex, "~> 2.0", only: [:dev, :test]}, | |||
| {:credo, "~> 1.7", only: [:dev, :test], runtime: false} | |||
| {:credo, "~> 1.7", only: [:dev, :test], runtime: false}, | |||
| {:styler, "~> 1.0.0-rc.0", only: [:dev, :test], runtime: false} | |||
There was a problem hiding this comment.
Oh is this still in rc status? 😞
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Styler and improving a case for the PNM format to act as in the other formats, in case the pnm signature is not fully formed, it won't parse the size. Test added to check proper behavior.
@warmwaffles Styler automatically refactored a few places, like the main file, tiff and pnm.
PNM Case:
Previous coverage:
Current coverage:
