Adds github workflow ci action #5
Conversation
|
I think supporting the latest 3 versions of OTP and elixir are preferable. As anything beyond is unsupported by upstream erlang and elixir doesn't push updates for older versions. |
mix.exs
Outdated
| docs: ["docs", ©_doc_to_docs/1] | ||
| docs: ["docs", ©_doc_to_docs/1], | ||
| lint: [ | ||
| "format --check-formatted", |
There was a problem hiding this comment.
Format fails because the .formatter.exs is not present at the project root level. And if you add one, it causes a ton of file churn. Not sure if we want to keep this.
There was a problem hiding this comment.
If the current indentation and formatting is good and clear, we can keep it like as is. If at some point you consider that would be an improvement, by applying an automatic formatter (like styler), go for it.
There was a problem hiding this comment.
I think we can probably drop it. It'll add file churn that will muddy the blame up.
|
Good one! Thanks! |
warmwaffles
force-pushed
the
github-actions
branch
2 times, most recently
from
bf08877
to
b9d6dde
Compare
|
I need #7 to land before this one does. There's some funkyness with credo. |
|
Other PRs are squashed+merged. Some of these CI tasks are failing due to a nested dependency (JSX). |
warmwaffles
force-pushed
the
github-actions
branch
from
b9d6dde
to
fd90bc2
Compare
|
Awesome, rebased and now just the linter fails. Will get that rectified. |
|
@rNoz linter fixed and now everything passes. EDIT: I also agree with the squash merge philosophy for libraries. Keeps the history nice and linear. |
This is to replace Travis.
I'm working on another branch to modernize this up to latest Elixir and OTP