Refactoring, positioning fix and pushing towards #364

[schnittchen]

I did only a very superficial test and it "works for me".

I can set the display_n setting to -1 (using gconf-editor) and have the window appear on my primary monitor.

[gsemet]

I don't understand your question.

I agree on the patch, however "-1" should be available in the preference window.

[schnittchen]

Next thing would be to use a constant instead of just -1, for readibility.

I doubt I can manage the necessary changes in the front-end, having no gtk experience at all :(

[schnittchen]

Update: prefs UI update upcoming.

[schnittchen]

Is 6dd227b a bad idea?
It removes a gconf key that is still referenced by some comments, but not by any code.

When the configured monitor does not exist, the comment says it falls back to primary_display option, but instead falls back on the mouse option. I wonder if it should now instead fall back to the new "always on primary" option.

[gsemet]

I would not force people to use mouse monitor. I kind of like the possibility to choose whether we want to display the terminal on the primary or secondary monitor, and in option on the monitor where the mouse is (and for me it should be the default option).

Idealy the combo box should have the following items:

• "Monitor where the mouse is"
• "Primary monitor"
• "Secondary monitor" (only displayed if more than one"
• and so on (let say that after monitor 8, we just display "On monitor N".

[gsemet]

I also think 6dd227b duplicate a feature, useless now.

[schnittchen]

I think X has no notion of secondary monitor. There is monitors 0, 1, 2... and one of them is flagged primary (which is not necessarily 0). This leaves us with n+2 options, n for each monitor, "always on monitor" and "mouse".

Maybe pushing these additional options into the combo box is not such a good idea, because the iter_ stuff is really fiddly.

I believe the code is technically OK now, however, do we really want to encode the new option as display_n == -1?

[schnittchen]

ping

[gsemet]

I had no time this week to test this quite impact patch, unfortunately :(

[gsemet]

I just found one small bug, sometime when we switch the windows and let the terminal opened, it does not display on the expected display

[schnittchen]

Thanks for merging.

Does toggling visibility twice make it appear on the right display again? Are all of the display_n options affected?