Skip to content

Commit

Permalink
Close file handle in ConfigurationWriter
Browse files Browse the repository at this point in the history
  • Loading branch information
dimitrisAnyfantakis authored and jelle-dc committed Nov 3, 2023
1 parent 836253f commit e76e479
Showing 1 changed file with 7 additions and 8 deletions.
15 changes: 7 additions & 8 deletions base/src/main/java/proguard/ConfigurationWriter.java
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ public class ConfigurationWriter implements AutoCloseable

private final PrintWriter writer;
private File configurationFile;
private File baseDir;
private String baseDirName;


/**
Expand All @@ -62,7 +62,10 @@ public ConfigurationWriter(File configurationFile) throws IOException
this(PrintWriterUtil.createPrintWriterOut(configurationFile));

this.configurationFile = configurationFile;
baseDir = configurationFile.getParentFile();
if (configurationFile.getParentFile() != null)
{
baseDirName = configurationFile.getParentFile().getAbsolutePath() + File.separator;
}
}


Expand Down Expand Up @@ -801,13 +804,9 @@ private String relativeFileName(File file)
String fileName = file.getAbsolutePath();

// See if we can convert the file name into a relative file name.
if (baseDir != null)
if (baseDirName != null && fileName.startsWith(baseDirName))
{
String baseDirName = baseDir.getAbsolutePath() + File.separator;
if (fileName.startsWith(baseDirName))
{
fileName = fileName.substring(baseDirName.length());
}
fileName = fileName.substring(baseDirName.length());
}

return quotedString(fileName);
Expand Down

0 comments on commit e76e479

Please sign in to comment.