Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS parser doesn't handle colors in functions #507

Closed
GuillaumeGomez opened this issue May 19, 2023 · 0 comments · Fixed by #508 or rust-lang/rust#111844
Closed

CSS parser doesn't handle colors in functions #507

GuillaumeGomez opened this issue May 19, 2023 · 0 comments · Fixed by #508 or rust-lang/rust#111844

Comments

@GuillaumeGomez
Copy link
Owner

For example this isn't converted as it should:

color: linear-gradient(rgba(15, 20, 25, 1), rgba(15, 20, 25, 0));

It comes from https://github.com/rust-lang/rust/blob/master/tests/rustdoc-gui/scrape-examples-color.goml.

Dylan-DPC added a commit to Dylan-DPC/rust that referenced this issue May 22, 2023
…lor-4, r=notriddle

Migrate GUI colors test to original CSS color format

I updated the `browser-ui-test` version because I fixed GuillaumeGomez/browser-UI-test#507. If inside a function, the colors were not considered, preventing the second commit of this PR.

Follow-up of rust-lang#111459.

r? `@notriddle`
oli-obk pushed a commit to oli-obk/miri that referenced this issue May 23, 2023
…notriddle

Migrate GUI colors test to original CSS color format

I updated the `browser-ui-test` version because I fixed GuillaumeGomez/browser-UI-test#507. If inside a function, the colors were not considered, preventing the second commit of this PR.

Follow-up of rust-lang/rust#111459.

r? `@notriddle`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant