Change Disk::file_system() to return &OsStr
#1107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chklauser
force-pushed
the
disk-file-system-to-os-str
branch
from
68923d2 to
24b2d37
Compare
chklauser
force-pushed
the
disk-file-system-to-os-str
branch
from
24b2d37 to
ced0029
Compare
Merged
|
Some questions and potentially improvement but otherwise it'll greatly improve the API. Thanks a lot for suggesting and doing it! |
GuillaumeGomez
approved these changes
Oct 22, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #1105, this PR changes the public interface
Disk::file_system()to return an&OsStrinstead of a&[u8].(I've decided to move the MSRV change into a separate PR #1108 because there is really no connection between these two PRs)