fix(linux): add distribution name before version #1426
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayn2op
changed the title
|
Is it ok with you @dtolnay ? |
dtolnay
suggested changes
Dec 11, 2024
There was a problem hiding this comment.
-
This is going to produce strings like "Android Pixel 9 15" on Android which is a regression from the current behavior.
-
Please update the examples in the public
long_os_versionfunction in src/common/system.rs. -
Some distributions already include "Linux" in
NAMEin/etc/os-release. For example on Fedora this would return "Linux Fedora Linux 40" which is maybe more confusing than the current behavior. Consider filtering for names that already contain Linux.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1420