-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add possibility to use question marks in days and weekdays #3
Add possibility to use question marks in days and weekdays #3
Conversation
Thanks for the contribution @miboz! Since this appears to be a non-standard character, I think it should be behind a flag, similarly to alias and seconds. Not all systems would accept it I believe. https://en.wikipedia.org/wiki/Cron#Non-standard_characters What do you think? If so, how could it be named? |
Thank you for your quick response @GuillaumeRochat ! Yes, you are totally right, I think it should be a flag too. As of the name of the flag, I am not sure what would be the best fit. Maybe something like "optional-day-format" or simply "question-mark" ? |
@miboz A quick search only shows up We can make it simple, use The downside of calling it just Sources : |
@GuillaumeRochat Indeed, I agree, As for the name of the flag that should be used, I must admit that I do not have many ideas. Here are the few ideas that I had: And do not hesitate to suggest flag names if you think of anything! |
@miboz How about
|
@GuillaumeRochat It sounds like a good name to me! It corresponds the best to the wikipedia definition. |
@miboz Good! I'll review again once you added the flag checks. If you need any more inputs for doing so, let me know. |
@GuillaumeRochat Perfect! Thank you for everything! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything else looks perfect. 👍
@miboz Oh also, add an example in the readme! I almost forgot about that part. |
Co-Authored-By: Guillaume Rochat <rochat.guillaume@gmail.com>
Thanks again for the contribution! Really appreciated. |
No description provided.