Mirror fixes

CSV file black input error solved Readme Update Added Maven Wrapper
Guleri24 · Apr 2, 2022 · 1b35ebc · 1b35ebc
1 parent c153339
commit 1b35ebc
Show file tree

Hide file tree

Showing 3 changed files with 30 additions and 8 deletions.
diff --git a/README.md b/README.md
@@ -1,4 +1,21 @@
-# Java + Maven + GitHub Actions = Native Desktop Apps
+# FIS Global
+## To run this application from the source
+`./mvnw clean javafx:run` in linux
+
+`mvnw.cmd clean javafx:run` in windows
+
+## Requirement for this project
+JDK 17 only and the rest is pulled by the mvn wrapper for you.
+
+## To create application packages
+1. Push the edits
+2. Follow these steps to build your package using GitHub actions
+![](docs/GitHub-Actions.png)
+In the 3rd case, when you click the button there is option to build the latest push using GitHub Action.
+You basically request GitHub to build this package for me.
+3. And Similar for other OS's like Mac (.dmg) and Linux (.deb, .rpm)
+
+## Java + Maven + GitHub Actions = Native Desktop Apps
 
 [JavaFX](https://openjfx.io) or Swing + [jpackage](https://docs.oracle.com/en/java/javase/15/docs/specs/man/jpackage.html) +
 [Maven](http://maven.apache.org) template project for generating native desktop applications.

diff --git a/pom.xml b/pom.xml
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<project xmlns="http://maven.apache.org/POM/4.0.0"
-         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+<project xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xmlns="http://maven.apache.org/POM/4.0.0"
          xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
     <modelVersion>4.0.0</modelVersion>
 
@@ -118,7 +118,7 @@
                 <artifactId>maven-dependency-plugin</artifactId>
                 <executions>
                     <execution>
-                        <!-- This copies all of the jar files declared by the Maven build into a single directory.
+                        <!-- This copies all the jar files declared by the Maven build into a single directory.
                         This makes it easy to assemble the final installer package -->
                         <id>copy-dependencies</id>
                         <phase>package</phase>
@@ -127,7 +127,7 @@
                         </goals>
                         <configuration>
                             <!-- The JavaFX libraries are bundled into the custom JVM, so we don't want to duplicate
-                            them in the bundled app and installer. This command skips all of the JavaFX by groupId. -->
+                            them in the bundled app and installer. This command skips all the JavaFX by groupId. -->
                             <excludeGroupIds>org.openjfx</excludeGroupIds>
                         </configuration>
                     </execution>

diff --git a/src/main/java/com/horizonxe/MainController.java b/src/main/java/com/horizonxe/MainController.java
@@ -88,10 +88,15 @@ private void initData() throws IOException {
         BufferedReader csvReader = new BufferedReader(new FileReader(dataFile));
         while ((row = csvReader.readLine()) != null) {
             String[] data = row.split(",");
-            if (!Objects.equals(data[0], ""))
+            if (data.length > 1) {
+                if (!data[0].isBlank())
+                    projects.add(data[0]);
+                if (!data[1].isBlank())
+                    modules.add(data[1]);
+            }
+            else {
                 projects.add(data[0]);
-            if (!Objects.equals(data[1], ""))
-                modules.add(data[1]);
+            }
         }
         csvReader.close();