📝 Improve components type hinting

GusFurtado · Jun 14, 2022 · 7aea4bb · 7aea4bb
1 parent 9764cf2
commit 7aea4bb
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 11 deletions.
diff --git a/dash_charlotte/components/box.py b/dash_charlotte/components/box.py
@@ -2,6 +2,7 @@
 from uuid import uuid4
 
 from dash import html
+from dash.development.base_component import Component
 
 
 
@@ -47,13 +48,13 @@ class Box(html.Div):
 
     def __init__(
             self,
-            children = None,
-            title = None,
-            subtitle = None,
+            children: Optional[Component] = None,
+            title: Optional[Component] = None,
+            subtitle: Optional[Component] = None,
             title_color: str = 'blue',
             title_style: Optional[dict] = None,
             icon: Optional[str] = None,
-            header_content = None,
+            header_content: Optional[Component] = None,
             style: Optional[dict] = None,
             padding: float = 10,
             id: Optional[str] = None

diff --git a/dash_charlotte/components/dashboard.py b/dash_charlotte/components/dashboard.py
@@ -1,6 +1,11 @@
+from typing import Optional
+
 from dash import dcc, html
+from dash.development.base_component import Component
 from dash_bootstrap_components import Container
 
+from . import Drawer, Navbar
+
 
 
 class Dashboard(Container):
@@ -30,9 +35,9 @@ class Dashboard(Container):
 
     def __init__(
             self,
-            children = None,
-            navbar = None,
-            drawer = None,
+            children: Optional[Component] = None,
+            navbar: Optional[Navbar] = None,
+            drawer: Optional[Drawer] = None,
             id: str = 'dashboard'
         ):
 

diff --git a/dash_charlotte/components/footer.py b/dash_charlotte/components/footer.py
@@ -2,6 +2,7 @@
 from uuid import uuid4
 
 from dash import html
+from dash.development.base_component import Component
 
 
 
@@ -30,8 +31,8 @@ class Footer(html.Footer):
 
     def __init__(
             self,
-            left_text: Optional[str] = None,
-            right_text: Optional[str] = None,
+            left_text: Optional[Component] = None,
+            right_text: Optional[Component] = None,
             id: Optional[str] = None
         ):
 

diff --git a/dash_charlotte/components/navbar.py b/dash_charlotte/components/navbar.py
@@ -1,4 +1,4 @@
-from typing import Optional, Union
+from typing import Optional
 import uuid
 
 from dash import html
@@ -9,7 +9,7 @@
 class Navbar(html.Nav):
     def __init__(
             self,
-            title: Union[str, Component],
+            title: Component,
             children: Optional[Component] = None,
             id: Optional[str] = None
         ):