Refacto: modernize config date from meta #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #285 +/- ##
==========================================
- Coverage 83.12% 82.16% -0.96%
==========================================
Files 10 10
Lines 551 555 +4
Branches 116 116
==========================================
- Hits 458 456 -2
- Misses 64 68 +4
- Partials 29 31 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Guts
added a commit
that referenced
this pull request
Jun 10, 2024
Since some advanced types operations introduced in mkdocs>=1.5 are not entirely supported by Python 3.8 and 3.9, let's switch to 3.10 as minimal version: Logs with failing error in #285 (https://github.com/Guts/mkdocs-rss-plugin/actions/runs/9450849461/job/26030426819?pr=285): > FAILED tests/test_build.py::TestBuildRss::test_simple_build_custom_output_basename - TypeError: Subscripted generics cannot be used with class and instance checks ```python /opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/mkdocs/plugins.py:96: in load_config return self.config.validate() /opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/mkdocs/config/base.py:231: in validate run_failed, run_warnings = self._validate() /opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/mkdocs/config/base.py:188: in _validate self[key] = config_option.validate(value) /opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/mkdocs/config/base.py:55: in validate return self.run_validation(value) /opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/mkdocs/config/config_options.py:110: in run_validation failed, warnings = config.validate() /opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/mkdocs/config/base.py:231: in validate run_failed, run_warnings = self._validate() /opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/mkdocs/config/base.py:188: in _validate self[key] = config_option.validate(value) /opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/mkdocs/config/config_options.py:186: in validate return self.run_validation(value) /opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/mkdocs/config/config_options.py:344: in run_validation if not isinstance(value, self._type): /opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/typing.py:769: in __instancecheck__ return self.__subclasscheck__(type(obj)) _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ ```
…ct-based SubConfig
Guts
force-pushed
the
refacto/modernize-config-date-from-meta
branch
from
d3638d5
to
6d0ab3e
Compare
for more information, see https://pre-commit.ci
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.