Test final changes with ubuntu

Guysnacho · Jul 17, 2024 · 002f755 · 002f755
1 parent 49e4932
commit 002f755
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 7 deletions.
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -7,7 +7,7 @@ name: 🌱 Apply, Build, Deploy 🌿
 jobs:
   TF-Apply:
     name: 🏗️ Apply Infra
-    runs-on: macos-latest
+    runs-on: ubuntu-latest
     steps:
       - name: Check Out
         uses: actions/checkout@v4

diff --git a/.github/workflows/predeploy.yml b/.github/workflows/predeploy.yml
@@ -10,7 +10,7 @@ name: 🌱 Plan, Build 🧪
 jobs:
   TF-Apply:
     name: 🏗️ Plan Infra
-    runs-on: macos-latest
+    runs-on: ubuntu-latest
     steps:
       - name: Check Out
         uses: actions/checkout@v4
@@ -30,7 +30,7 @@ jobs:
       - name: 🏗️ Terraform Plan
         run: |
           cd terraform
-          terraform apply -var="bucket-name=${{ secrets.S3_BUCKET }}"
+          terraform plan -var="bucket-name=${{ secrets.S3_BUCKET }}"
       - run: echo ${{ steps.plan.outputs.stdout }}
       - run: echo ${{ steps.plan.outputs.stderr }}
       - run: echo ${{ steps.plan.outputs.exitcode }}
@@ -62,6 +62,3 @@ jobs:
         run: |
           cd web
           npm run build
-
-      - name: 🚀 Upload Package
-        run: aws s3 sync ./web/out s3://${{ secrets.S3_BUCKET }}/ --region us-west-2
diff --git a/terraform/s3.tf b/terraform/s3.tf
@@ -20,7 +20,6 @@ module "s3-bucket" {
       }
     ]
   })
-  block_public_acls       = false
   attach_public_policy    = true
   restrict_public_buckets = false
   object_ownership        = "BucketOwnerPreferred"