Make ecr public

Guysnacho · Oct 18, 2024 · 43e3c32 · 43e3c32
1 parent 29c25c7
commit 43e3c32
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/.github/workflows/build_test.yml b/.github/workflows/build_test.yml
@@ -87,9 +87,10 @@ jobs:
         uses: docker/login-action@v3
         with:
           registry: ${{needs.TF-Apply.outputs.registry_url}}
+          ecr: true
           # We're already authenticated thanks to aws-actions/configure-aws-credentials
-          # username: ${{ secrets.AWS_ACCESS_KEY_ID }}
-          # password: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
+          username: ${{ secrets.AWS_ACCESS_KEY_ID }}
+          password: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
 
       - name: 🐳 Build Image
         uses: docker/build-push-action@v6

diff --git a/terraform/ecr.tf b/terraform/ecr.tf
@@ -17,7 +17,7 @@ module "public_ecr" {
   source = "terraform-aws-modules/ecr/aws"
 
   repository_name = local.ecr_name
-  repository_type = "private"
+  repository_type = "public"
 
   repository_read_write_access_arns = [data.aws_caller_identity.current.arn]
   repository_lifecycle_policy = jsonencode({