-
-
Notifications
You must be signed in to change notification settings - Fork 570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translation korean #128
Translation korean #128
Conversation
Thanks 🎉 Don't worry if you are not seeing Korean characters in the GUI, I just have to manually add them. |
}) | ||
} | ||
|
||
pub fn start_translation(language: Language) -> &'static str { | ||
match language { | ||
Language::EN | Language::DE | Language::RO => "Start!", | ||
Language::EN | Language::DE | Language::RO | Language::KO => "Start!", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this correct to remain "start"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left it because I thought it would look weird if I translate it.
It might be better to leave it as it is :)
src/translations/translations.rs
Outdated
@@ -1033,6 +1109,9 @@ pub fn no_notifications_set_translation(language: Language) -> Text<'static> { | |||
Language::RO => "Încă nu ați activat notificările!\n\n\ | |||
După ce le veți activa, această pagină va afișa un jurnal al notificărilor dvs\n\n\ | |||
Puteți activa notificările din setări:", | |||
Language::KO => "아직 알림을 활성화하지 않았습니다!\n\n\ | |||
활성화로 설정하면 이 페이지에 알림 로그가 표시됩니다\n\n\ | |||
You can enable notifications from settings:", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you missed this translation as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
opps. I missed the last sentence.
This sentence is "설정에서 알림을 활성화할 수 있습니다:" can be translated into
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't meticulous.
Thank you for finding my mistake 😄
}) | ||
} | ||
|
||
pub fn start_translation(language: Language) -> &'static str { | ||
match language { | ||
Language::EN | Language::DE | Language::RO => "Start!", | ||
Language::EN | Language::DE | Language::RO | Language::KO => "Start!", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left it because I thought it would look weird if I translate it.
It might be better to leave it as it is :)
src/translations/translations.rs
Outdated
@@ -1033,6 +1109,9 @@ pub fn no_notifications_set_translation(language: Language) -> Text<'static> { | |||
Language::RO => "Încă nu ați activat notificările!\n\n\ | |||
După ce le veți activa, această pagină va afișa un jurnal al notificărilor dvs\n\n\ | |||
Puteți activa notificările din setări:", | |||
Language::KO => "아직 알림을 활성화하지 않았습니다!\n\n\ | |||
활성화로 설정하면 이 페이지에 알림 로그가 표시됩니다\n\n\ | |||
You can enable notifications from settings:", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
opps. I missed the last sentence.
This sentence is "설정에서 알림을 활성화할 수 있습니다:" can be translated into
Amazing, thank you again 🎉 |
@all-contributors please add @DocRAID for translation. |
I've put up a pull request to add @DocRAID! 🎉 |
No description provided.