Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Birds aren't real... #1477

Merged
merged 1 commit into from
Sep 9, 2023
Merged

Birds aren't real... #1477

merged 1 commit into from
Sep 9, 2023

Conversation

Hoikas
Copy link
Member

@Hoikas Hoikas commented Aug 27, 2023

In evolutionary biology, we say that dinosaurs didn't die off... they simply flew away. In this case, we don't give a rat's about birds or dinosaurs. All these state descriptors that predate MOULa are of no practical use. They are merely historical curiosities. Therefore, we toss them. Culling all this old crap will be great for H-uru/dirtsand#184.

This removes all state descriptors that are from before the initial open
source release. These should not be in use anywhere in the wild that
uses this codebase.
Copy link
Contributor

@dgelessus dgelessus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff on GitHub looks weird in places because there are formatting/comment changes mixed in. I checked locally and everything looks good to me - there are no dangerous changes to the STATEDESCs that are not being deleted.

@dgelessus
Copy link
Contributor

I remembered again that #1254 still exists, so the second copies of animation.sdl and avatar.sdl will get further out of sync with this. I can fix that after this PR is merged though (#1254 could use a rebase anyway as it's almost a year old).

@Hoikas Hoikas merged commit 7e73665 into H-uru:master Sep 9, 2023
14 checks passed
@Hoikas Hoikas deleted the sdl_dinosaurs branch November 25, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants