Better edge case handling around Docker Compose v2 #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original version of Docker Compose was a separate utility, which provided a docker-compose command-line tool. Docker Compose v2 is a Docker plugin, which is meant to be run as a subcommand of Docker (i.e., `docker compose ...`). In most cases, it provides a `docker-compose` tool for backwards compatibility that forwards to the plugin, but in some cases that tool is either missing or not properly added to the path. We will therefore try to run `docker-compose`, and if it fails we will try to run `docker compose` and see if that works before exiting with an error. If `docker compose` is supported, we will use that for subsequent commands.
|
NOTE: Marking this as a draft until it's tested and confirmed working on a system that is lacking the EDIT: This appears to have worked, so I'm opening this up for review :) |
|
Is this supposed to be a branch on the H-uru repo? |
|
oops, I guess I don't have fork of DS and |
Hoikas
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original version of Docker Compose was a separate utility, which provided a docker-compose command-line tool.
Docker Compose v2 is a Docker plugin, which is meant to be run as a subcommand of Docker (i.e.,
docker compose ...). In most cases, it provides adocker-composetool for backwards compatibility that forwards to the plugin, but in some cases that tool is either missing or not properly added to the path.We will therefore try to run
docker-compose, and if it fails we will try to rundocker composeand see if that works before exiting with an error. Ifdocker composeis supported, we will use that for subsequent commands.