Merge pull request #287 from Hoikas/water_bounds

Fix handling of waveset bounding boxes.
H-uru · Jun 23, 2024 · f372a43 · f372a43
2 parents 1568702 + 1571eb4
commit f372a43
Showing 1 changed file with 31 additions and 7 deletions.
diff --git a/core/PRP/Geometry/plDrawableSpans.cpp b/core/PRP/Geometry/plDrawableSpans.cpp
@@ -531,14 +531,38 @@ void plDrawableSpans::calcBounds()
         hsBounds3Ext world;
 
         world.setFlags(hsBounds3Ext::kAxisAligned);
-        auto localPoints = std::make_unique<hsVector3[]>(verts.size());
-        auto worldPoints = std::make_unique<hsVector3[]>(verts.size());
-        for (size_t j = 0; j < verts.size(); j++) {
-            localPoints[j] = verts[j].fPos;
-            worldPoints[j] = fIcicles[i]->getLocalToWorld().multPoint(verts[j].fPos);
+        if (fIcicles[i]->getProps() & plSpan::kWaterHeight) {
+            constexpr float kMaxWaveHeight = 5.f;
+
+            auto localPoints = std::make_unique<hsVector3[]>(verts.size());
+            for (size_t j = 0; j < verts.size(); j++)
+                localPoints[j] = verts[j].fPos;
+            loc.setFromPoints(verts.size(), localPoints.get());
+
+            // Water is flattened at runtime to the water height Z
+            // coordinate. The bounding box needs to be bloated out
+            // a bit, though, to account for the maximum possible geometry
+            // waves.
+            hsVector3 reboundPts[]{ loc.getMins(), loc.getMaxs() };
+            for (hsVector3& pt : reboundPts)
+                pt = fIcicles[i]->getLocalToWorld().multPoint(pt);
+            reboundPts[0].Z = fIcicles[i]->getWaterHeight() - kMaxWaveHeight;
+            reboundPts[1].Z = fIcicles[i]->getWaterHeight() + kMaxWaveHeight;
+
+            world.setFromPoints(2, reboundPts);
+            for (hsVector3& pt : reboundPts)
+                pt = fIcicles[i]->getWorldToLocal().multPoint(pt);
+            loc.setFromPoints(2, reboundPts);
+        } else {
+            auto localPoints = std::make_unique<hsVector3[]>(verts.size());
+            auto worldPoints = std::make_unique<hsVector3[]>(verts.size());
+            for (size_t j = 0; j < verts.size(); j++) {
+                localPoints[j] = verts[j].fPos;
+                worldPoints[j] = fIcicles[i]->getLocalToWorld().multPoint(verts[j].fPos);
+            }
+            loc.setFromPoints(verts.size(), localPoints.get());
+            world.setFromPoints(verts.size(), worldPoints.get());
         }
-        loc.setFromPoints(verts.size(), localPoints.get());
-        world.setFromPoints(verts.size(), worldPoints.get());
         loc.unalign();
 
         fIcicles[i]->setLocalBounds(loc);