Add missing public getters and setters to various classes #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although there were already methods for getting, changing, adding, and removing elements, they couldn't be used safely from outside plClothingItem, because there was no way to get the number of elements, which is necessary to know which indices are valid for these methods.
zrax
reviewed
Mar 29, 2024
| @@ -20,30 +20,25 @@ | |||
| #include "PRP/plCreatable.h" | |||
| #include "Math/hsGeometry3.h" | |||
|
|
|||
| class HSPLASMA_EXPORT plVertDelta | |||
| struct HSPLASMA_EXPORT plVertDelta | |||
There was a problem hiding this comment.
Why were these changed to structs?
There was a problem hiding this comment.
It was the simplest way to make all the fields public. This seemed to be the convention in libHSPlasma for things that only hold simple data values.
But if you like, I can change it back to class and/or wrap the fields in getters/setters. I don't have opinions on the details here, as long as there's some way to access the data in the class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These classes were already fully implemented, but had no public API beyond the basic read/write methods, so there was no way to interact with them outside libHSPlasma. This PR adds getters and setters where appropriate and converts some classes to public structs.
This is a somewhat random selection of classes (I was experimenting with PrpShop and these are the ones I stumbled across). There are probably still more places that could use the same treatment.