Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some problems with Eder BS. #219

Merged
merged 8 commits into from
Apr 13, 2023
Merged

Fix some problems with Eder BS. #219

merged 8 commits into from
Apr 13, 2023

Conversation

Hoikas
Copy link
Member

@Hoikas Hoikas commented Feb 12, 2023 •
edited
Loading

This primarily fixes some logic problems in the blue spiral games as hosted in Eder Delin and Eder Tsogal. Currently, only the game master hears the sound effects played by the bahro spinner. This can potentially result in some problems with the door synchronization. I also worked around H-uru/Plasma#1317 in Eder Tsogal by removing the kPropDisableLOD.

Important gameplay fixes:

  • The bahro door now allows its sound effect triggers to be synchronized over the network. Previously, the responders explicitly disallowed this, meaning that only the game owner would hear the door sound effects.
  • Disabled the bahro door clickable when the door is not fully closed. This prevents spurious clicks by players during gameplay transition states.
  • Added a notification to the bahro door responder to inform the Python script when the door is opening. This allows improved door synchronization logic.

Some drive by QOL fixes:

  • Fixed the default link in point in Eder Tsogal to be on the ground (you no longer fall 5 feet when linking in).
  • Fixed all of the cloth seek points in Eder Tsogal to be on the ground (you no longer warp above or below the ground while pressing the cloth).
  • Fixed the seek point of the Neighborhood book in Eder Tsogal to be on the ground.
  • Added some blur scaling to the runtime shadows in Eder Tsogal to prevent jaggies.
  • Fixed the environment maps in Eder Delin and Eder Tsogal to be from the correct angle, greatly improving the reflections in the bahro door... mainly in Eder Tsogal
  • Fixed the seek point position of the bahro door in Eder Delin to be on the ground instead of a foot below the ground.
  • Fixed the Eder Delin bahro door to not fast forward open the first time the open animation is run.
  • Removed kPropDisableLOD from the Eder Tsogal bahro door loop sound effect.

Eder Tsogal Before:
image

Eder Tsogal After:
image

Should be merged with H-uru/Plasma#1309.

@Hoikas
Fix some problems with Eder Tsogal's BS.
1315425 
- plResponderModifier [cRespBSDoorOps], [cSfxRespBSrotation]
  Changed all plSoundMsgs in these responders to NOT use the command
  `kIsLocalOnly` - this command prevented non-owners from hearing the
  door sound effects.
- plPythonFileMod [cPythBlueSpiral]
  Added attributes 25 and 26 - BlueSpiral solution and running variable
  name strings.
- plCoordinateInterface [LinkInPointDefault]
  Moved the default link in point down to Z=-4 to fix the avatars
  visibly spawning high up in the air and falling.
@Hoikas
Update EderTsogal CubicEnvironmap for accuracy.
75c8eba 
The previous cubic environment map was taken from an angle that didn't
match its intended use case, causing the reflection in the Bahro door to
be very inaccurate.
@Hoikas
Fix some problems with Eder Delin's BS.
a4193bb 
- plResponderModifier [cRespBSDoorOps], [cSfxRespBSrotation]
  Changed all plSoundMsgs in these responders to NOT use the command
  `kIsLocalOnly` - this command prevented non-owners from hearing the
  door sound effects.
- plPythonFileMod [cPythBlueSpiral]
  Added attributes 25 and 26 - BlueSpiral solution and running variable
  name strings.
- plCoordinateInterface [tsglBlueSpiralDoorPOS]
  Moved the OneShot position up to z=-0.82 to prevent the player from
  noticably sinking into the ground when playing the door press
  animation at the bahro door.
@Hoikas
Update EderDelin CubicEnvironmap for accuracy.
b4f86ea 
The environment map was previously a duplicate of the incorrect
environment map from Eder Tsogal. The end result is a very slight change
in coloration at the top of the bahro door from white to pink. The bahro
door in Eder Delin is too shrouded in shadow for this change to be
readily apparent.
@Hoikas Hoikas mentioned this pull request Feb 13, 2023
Merged
@Hoikas Hoikas marked this pull request as ready for review February 13, 2023 01:33
@Hoikas
Eder BS door animation synchronization fixes.
9f3881e 
This hardens the logic of synchronizing the bahro door animations by
adding an extra notification to the Python script for when the bahro
door begins to open. This also fixes Eder Delin's bahro door
fast-forwarding open the first time the blue spiral game is completed in
that Age.

- [plResponderModifier] cRespBSDoorOps
  Added a `plNotifyMsg` back to the Python script at the beginning of
  the door open (first) responder state with a state of 0 to indicate
  that the door is not yet open. This change requires script changes.
- Eder Delin ONLY [plAGMasterMod] AnimGroupedBSdoorClose_0
  Removed the link to the owning `plMsgForwarder` - this link caused
  the door to fast-forward open. The field is nulled out in the Tsogal
  door, which is known to work correctly.
@Hoikas
Eder BS door clickable sanity fix.
735fa78 
This turns off the door clickable while the door is animating. This
should prevent the game state from changing due to unexpected user input
during transitions.

- [plResponderModifier] cRespBSDoorOps
  Disabled the door clickable when the door begins to open and re-enable
  it when the door fully closes. This is done in the responder itself
  instead of the code so that the clickable and visual states match
  exactly. Previously, the EderTsogal door sent an enable/disable to the
  clickable LogicModifier while the EderDelin door did nothing to try to
  prevent spurious clicks. The enable/disable of the logic modifier was
  maintained by routing the EnableMsg to the SceneObject with an
  instruction to enable/disable the physical and route the message to
  all modifiers.
@Hoikas
Fix a few more graphical problems in EderTsogal.
f317cdd 
This fixes the jagged shadow on the bahro door by increasing the shadow
caster's blur scale from 0 to 1. Also, some of the cloth seek points
have been adjusted to avoid placing the player slightly above and below
the ground.
@Hoikas
Further improve Eder BS door state tracking.
4cb6bfa 
This adds more notifications to the responder to track the door closing
state. This was done to fix some problems observed with the door
clickable being re-enabled by the Python script racing the responder.
Also, fix the door clickable responder in Eder Tsogal to properly
enable/disable the clickable.

- [plResponderModifier] cRespBSDoorOps
  Added new plNotifyMsgs for door closing and changed the state numbers
  to match the enum in xBlueSpiral.py. Also fixed Eder Tsogal's
  responder to properly enable/disable the door clickable, which must
  have been missed in the earlier commit.
@Hoikas Hoikas added the blocking on moula This pull request or issue is blocking on a corresponding MOULa update. label Feb 23, 2023
@Hoikas Hoikas merged commit 2067339 into H-uru:master Apr 13, 2023
@Hoikas Hoikas deleted the bs-gardens branch April 13, 2023 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
blocking on moula This pull request or issue is blocking on a corresponding MOULa update.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Hoikas