Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add W5500 SPI Ethernet #343

Merged
merged 5 commits into from
Jun 11, 2022
Merged

Conversation

bensuffolk
Copy link
Contributor

Additional files and configuration to build W5500 SPI Ethernet functionality, along with a a lanbon build options ini file

@fvanroie fvanroie changed the base branch from master to feature/w5500 June 11, 2022 14:05
@fvanroie fvanroie merged commit bab26ff into HASwitchPlate:feature/w5500 Jun 11, 2022
@fvanroie
Copy link
Collaborator

fvanroie commented Jun 11, 2022

This is great! It seems the ETH and ETHSPI classes are nearly identical, except the begin() method.

To reduce code duplication, I'd propose to merge the src\sys\net\hasp_ethernet_esp32.cpp and src\sys\net\hasp_ethernet_spi.cpp files and create an HASP_ETHERNET flag to define either the ETH or ETHSPI class.

I can't test it but I've updated master and it compiles fine. Can you give it a go? 0f95052
I need to get some W5500 modules to properly test...

@nagyrobi
Copy link
Collaborator

I need to get some W5500 modules to properly test...

Yeah me too. Any advice which ones worth best?

@bensuffolk
Copy link
Contributor Author

Yes I will test in a couple of days when I’m back at home. I use the cheap usr-es1 from Ali express. About £3.50 ish each. Never had any issues with them and I have used about 30 or so in projects for the last few years.

@bensuffolk
Copy link
Contributor Author

Ok, Have tested, network is ok, I can access the web and telnet, but MQTT won't connect. I shall have to investigate and see if I can find out why.

@bensuffolk
Copy link
Contributor Author

I have created a new pull request #345 to fix MQTT on Ethernet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants