Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix scroll top #280

Closed
wants to merge 1 commit into from
Closed

fix scroll top #280

wants to merge 1 commit into from

Conversation

lipp
Copy link
Contributor

@lipp lipp commented Mar 22, 2017

scroll top (animation) stopped working somehow at sometime :(

test have a warning related to router which will be fixed with #277 .

this fixes the scrolling. please try it out.

@lipp lipp requested a review from zemirco March 22, 2017 09:41
@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 96.345% when pulling 52455a4 on fix-bottomnav-scrolltop into a9a3e23 on master.

zemirco
zemirco approved these changes Mar 22, 2017
View reviewed changes
Copy link
Contributor

@zemirco zemirco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. plz fix merge conflicts

@lipp lipp closed this Mar 22, 2017
@lipp lipp deleted the fix-bottomnav-scrolltop branch March 22, 2017 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zemirco zemirco zemirco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lipp @coveralls @zemirco