Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional methods for testing DAX clusters #11

Merged
merged 7 commits into from
Nov 11, 2021
Merged

Additional methods for testing DAX clusters #11

merged 7 commits into from
Nov 11, 2021

Conversation

yardbirdsax
Copy link
Member

@yardbirdsax yardbirdsax commented Nov 10, 2021 •
edited
Loading

SUMMARY

  • This partially fixes Add methods for DAX cluster testing #10.
  • We added several new methods to the AWS package around testing DAX clusters:
    • AssertDAXClusterEncrypted - asserts that a DAX cluster has server side encryption enabled.
    • AssertDAXClusterSubnetGroup - asserts that a DAX cluster is assigned to a given subnet group.
    • AssertDAXClusterSecurityGroup - asserts that a DAX cluster is associated with a given security group (not exclusive).
  • We added a helper method to the AWS package for retrieving EC2 security groups by name (GetEC2SecurityGroupByName).
  • We added a new Makefile target for generating mocks for client interfaces using gomock.

DEVELOPER IMPACT

  • There is no impact to any existing use of the module since these are all new methods.
  • A new reference to the gomock module has been added since it is required to more easily generate mocks of interfaces for clients.

Contribution Checklist

  • All changes have been reflected in comparable unit test changes or additions.
  • Any interactions with third party clients are done via interface types rather than direct interactions.
  • All new functions follow the required naming standard.
  • All new functions follow the required signature standards.

PIC

Embed something funny here

@yardbirdsax
Added new DAX method
8650061 
A new method for asserting that a DAX cluster has encryption enabled has been added.
@yardbirdsax
New Make target for mocking
0646ef1 
A new Makefile target for generating mocks of client interfaces has been added.
@yardbirdsax
Added DAX method
c1670f8 
A method to assert that a DAX cluster is associated with a given subnet group has been added.
@yardbirdsax
Added new EC2 mock type
79fa1f6 
A new EC2 mock type has been added.
@yardbirdsax
Added EC2 method
00778e0 
A method to retrieve an EC2 security group by name has been added.
@yardbirdsax
Added DAX method for security group
3be0151 
A method for asserting a DAX cluster is associated with a given security group has been added.
@yardbirdsax yardbirdsax changed the title Feature/dax Additional methods for testing DAX clusters Nov 10, 2021
@yardbirdsax yardbirdsax marked this pull request as ready for review November 10, 2021 18:26
@yardbirdsax yardbirdsax requested a review from a team as a code owner November 10, 2021 18:26
@yardbirdsax
Refactored DAX methods
c0ec1db 
The current DAX methods have been refactored to use a common method for retrieving DAX clusters by name.
sunkaraamrutha
sunkaraamrutha approved these changes Nov 11, 2021
View reviewed changes
Copy link
Contributor

@sunkaraamrutha sunkaraamrutha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yardbirdsax yardbirdsax merged commit e57701b into main Nov 11, 2021
@yardbirdsax yardbirdsax deleted the feature/dax branch November 11, 2021 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunkaraamrutha sunkaraamrutha sunkaraamrutha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add methods for DAX cluster testing
2 participants
@yardbirdsax @sunkaraamrutha