Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data.Frame event #38

Merged
merged 1 commit into from
Mar 31, 2016
Merged

Add data.Frame event #38

merged 1 commit into from
Mar 31, 2016

Conversation

jafyvilla
Copy link
Contributor

The new event defines a data frame range, containing
the 'start' and 'end' frame numbers coming from a certain
data source.

The new event defines a data frame range, containing
the 'start' and 'end' frame numbers coming from a certain
data source.
// units as the zerobuf.render.Frame, i.e. number of frames.
// It may be used as a base event that defines the available range of frames
// coming from a certain data source, being also possible to use the
// zerobuf.render.Frame event at the same time, which would define the frame
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all could have been handled in the GUI, why did we add a new event ?
The GUI is the one who commands a frame ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The GUI only knows what it receives from Livre, which at the moment is the render.Frame event (start, current, end, delta). Now, Livre and the GUI are using this interval of frames to loop between them in an animation, and this range can also be modified from the GUI, being possible to focus on a specific segment of the visualization.
This new data.Frame event is adding semantics for the range of frames that the data source provides, so we can easily know the available range from the GUI, but at the same time change the range within which the rendering should animate.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We ( @favreau and I ) had this conclusion 6 months ago and it was rejected :) Anyways good to have it.

@eile
Copy link
Contributor

eile commented Mar 30, 2016

+1

@jafyvilla jafyvilla merged commit fc4b0bd into HBPVIS:master Mar 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants