Removed CreateBinding() method #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What is the status on this? I would definitely like the normal binding because for example i need valueconverters |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically I've removed the IncrementalTableViewSource.CreateBinding() so we can easily migrate the code from any MvxTableViewSource to IncrementalTableViewSource.
Developers will have to set the binding like they always do when using any other MvxTableViewSource subclass.
eg. this.CreateBinding(source).To(vm => vm.Numbers).Apply();
Both the iOS and Android implementations are similar and both are overriding ItemsSource property to reset the _lastViewedPosition.
I also improved the .gitignore