Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASA-9201: Enable Secrets Scanning #174

Merged
merged 10 commits into from
Nov 14, 2024
Merged

ASA-9201: Enable Secrets Scanning #174

merged 10 commits into from
Nov 14, 2024

Conversation

michaela-perrotta
Copy link

@CLAassistant
Copy link

CLAassistant commented Nov 12, 2024

CLA assistant check
All committers have signed the CLA.

@michaela-perrotta michaela-perrotta requested review from lukesantoro and bao-lu and removed request for bao-lu and lukesantoro November 12, 2024 16:06
Copy link

@mattmurp mattmurp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to differentiate between noSecrets and disableSecrets since they do the same thing. Instead, we can simply set noSecrets="true" as the attribute for the disableSecrets option.

@michaela-perrotta michaela-perrotta merged commit 7e7d7c0 into master Nov 14, 2024
2 checks passed
@michaela-perrotta michaela-perrotta deleted the ASA-9201 branch November 14, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants