Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

H5Pset_libver_bounds docs need to be updated #3524

Closed
bmribler opened this issue Sep 8, 2023 · 0 comments
Closed

H5Pset_libver_bounds docs need to be updated #3524

bmribler opened this issue Sep 8, 2023 · 0 comments
Assignees
@bmribler @vchoi-hdfgroup
Labels
Component - Documentation Doxygen, markdown, etc. Merge - To 1.14 This needs to be merged to HDF5 1.14 Type - Improvement Improvements that don't add a new feature or functionality
Milestone
1.14.3

Comments

@bmribler
Copy link
Contributor

bmribler commented Sep 8, 2023

From a user:

I went looking for docs on H5Pset_libver_bounds in both 1.12 and 1.14 docs and it mentions only up to version V110 there.

I suspect these docs have not been updated to address behavior for 1.12 and/or 1.14.

At least thats what it looks like to me.

Also, the table describing the behavior for various pairs of args seems a tad inconsistent.

For example, for EARLIEST/V18 pair, it mentions that calls to create objects or use features that are available to versions of the library greater than 1.8 will fail whereas in the EARLIEST/V110 pair, it does not mention this.

There is no pair in the table for LATEST/LATEST and what that means and it would seem the table needs to describe a much larger number of pairs than it does. For example, V18/V112.
@bmribler bmribler added Merge - To 1.12 Merge - To 1.14 This needs to be merged to HDF5 1.14 Component - Documentation Doxygen, markdown, etc. Type - Improvement Improvements that don't add a new feature or functionality Branch - 1.14 PRs to hdf5_1_14 labels Sep 8, 2023
@derobins derobins added this to the 1.14.3 milestone Oct 4, 2023
bmribler added a commit that referenced this issue Oct 17, 2023
@bmribler
Fixed #3524
ce6d495 
Added 1.12, 1.14, and 1.16 to the table for libver bounds in the H5Pset_libver_bounds docs.
@derobins derobins mentioned this issue Oct 18, 2023
Merged
@lrknox lrknox closed this as completed in 709367c Oct 20, 2023
jhendersonHDF pushed a commit to jhendersonHDF/hdf5 that referenced this issue Oct 20, 2023
@bmribler @jhendersonHDF
Update the library version matrix for H5Pset_libver_bounds() (HDFGrou…
7804d75 
…p#3702)

* Fixed HDFGroup#3524

Added 1.12, 1.14, and 1.16 to the table for libver bounds in the H5Pset_libver_bounds docs.
derobins added a commit that referenced this issue Oct 21, 2023
@jhendersonHDF @hyoklee
@byrnHDF @brtnfld @derobins @fortnern @glennsong09 @bmribler
Sync with develop (#3737)
b16808d 
* Correct ld in format strings in cmpd_dset.c (#3697)

Removes clang warnings

* Clean up comments. (#3695)

* Add NVidia compiler support and CI (#3686)

* Work around Theta system issue failure in links test (#3710)

When the Subfiling VFD is enabled, the links test may
try to initialize the Subfiling VFD and call MPI_Init_thread.
On Theta, this appears to have an issue that will cause
the links test to fail. Reworked the test to check for
the same conditions in a more roundabout way that doesn't
involved initializing the Subfiling VFD

* Fix issue with unmatched messages in ph5diff (#3719)

* provide an alternative to mapfile for older bash (#3717)

* Attempt to quiet some warnings with cray compilers. (#3724)

* Fix CMake VOL passthrough tests by copying files to correct directory (#3721)

* Develop intel split (#3722)

* Split intel compiler flags into sub-folders
* Update Intel options for warnings
* Mostly CMake, Autotools needs additional work

* Fixes and adjustments to t_filters_parallel (#3714)

Broadcast number of datasets to create in multi-dataset I/O cases
so that interference with random number generation doesn't cause
mismatches between ranks

Set fill time for datasets to "never" by default and adjust on a
per-test basis to avoid writing fill values to chunks when it's
unnecessary

Reduce number of loops run in some tests when performing multi-dataset
I/O

Fix an issue in the "fill time never" test where data verification
could fill if file space reuse causes application buffers to be
filled with chosen fill value when reading from datasets with
uninitialized storage

Skip multi-chunk I/O test configurations for multi-dataset I/O
configurations when the TestExpress level is > 1 since those
tests can be more stressful on the file system

Disable use of persistent file free space management for now
since it occasionally runs into an infinite loop in the library's
free space management code

* Suppress cast-qual warning in H5TB Fortran wrapper (#3728)

This interface is fundamentally broken, const-wise.

* Add new API function H5Pget_actual_select_io_mode() (#2974)

This function allows the user to determine if the library performed selection I/O, vector I/O, or scalar (legacy) I/O during the last HDF5 operation performed with the provided DXPL. Expanded existing tests to check this functionality.

* Test scripts now execute in-source with creation of tmp dir (#3723)

Fixes a few issues created in #3580:

* Fixes a problem where committed tools test files were deleted when cleaning after an in-source build
* Fixes issues with test file paths in Autotools tools test scripts

* Add -h and --help as flags in h5cc & h5fc (#3729)

Adds these common help flags in addition to -help

* Update the library version matrix for H5Pset_libver_bounds() (#3702)

* Fixed #3524

Added 1.12, 1.14, and 1.16 to the table for libver bounds in the H5Pset_libver_bounds docs.

* Remove references to LIBVER_V116

---------

Co-authored-by: H. Joe Lee <hyoklee@hdfgroup.org>
Co-authored-by: Allen Byrne <50328838+byrnHDF@users.noreply.github.com>
Co-authored-by: Scot Breitenfeld <brtnfld@hdfgroup.org>
Co-authored-by: Dana Robinson <43805+derobins@users.noreply.github.com>
Co-authored-by: Neil Fortner <fortnern@gmail.com>
Co-authored-by: Glenn Song <43005495+glennsong09@users.noreply.github.com>
Co-authored-by: bmribler <39579120+bmribler@users.noreply.github.com>
bmribler added a commit to bmribler/hdf5_bmr23 that referenced this issue Oct 22, 2023
@bmribler
More updates to the library version matrix for H5Pset_libver_bounds()
bd5a921 
Fixes GitHub HDFGroup#3524 in 1.14
@bmribler bmribler mentioned this issue Oct 22, 2023
Merged
derobins pushed a commit that referenced this issue Oct 23, 2023
@bmribler
More updates to the library version matrix for H5Pset_libver_bounds() (…
d3a5008 
…#3745)

Fixes GitHub #3524 in 1.14
@bmribler bmribler mentioned this issue Oct 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmribler bmribler

@vchoi-hdfgroup vchoi-hdfgroup

Labels
Component - Documentation Doxygen, markdown, etc. Merge - To 1.14 This needs to be merged to HDF5 1.14 Type - Improvement Improvements that don't add a new feature or functionality
Projects
None yet
Milestone
1.14.3
Development

No branches or pull requests
3 participants
@derobins @bmribler @vchoi-hdfgroup