Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The ${HDF5_CXXLINKER} does not work in h5c++ #924

Closed
lrknox opened this issue Aug 18, 2021 · 1 comment
Closed

The ${HDF5_CXXLINKER} does not work in h5c++ #924

lrknox opened this issue Aug 18, 2021 · 1 comment

Comments

@lrknox
Copy link
Collaborator

lrknox commented Aug 18, 2021

Reported in pull request #775 by @WaldonChen, along with fix in line 96 to correct HDF5_CLINKER to HDF5_CXXLINKER.

PR #775 was submitted against 1.12/master branch, but needs to go to develop, then to hdf5_1_12 and hdf5_1_10 to appear in upcoming releases.
This was referenced Aug 18, 2021
Merged
Merged
lrknox added a commit that referenced this issue Aug 19, 2021
@lrknox @github-actions
Fix issue #924 in develop branch: the ${HDF5_CXXLINKER} does not work…
564380d 
… in h5c++ (#925)

* Committing clang-format changes

* Fix issue #924, ${HDF5_CXXLINKER} does not work in h5c++.
2 instances of CLINKER corrected to CXXLINKER
comment border aligned

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
lrknox added a commit that referenced this issue Aug 19, 2021
@lrknox
Fix issue #924, ${HDF5_CXXLINKER} does not work in h5c++. (#926)
1080a22 
2 instances of CLINKER corrected to CXXLINKER
comment border aligned
lrknox added a commit that referenced this issue Aug 19, 2021
@lrknox
Fix issue #924, ${HDF5_CXXLINKER} does not work in h5c++. (#938)
325babf 
2 instances of CLINKER corrected to CXXLINKER
comment border aligned
@lrknox lrknox mentioned this issue Aug 19, 2021
Closed
@lrknox lrknox closed this as completed Aug 19, 2021
@lrknox
Copy link
Collaborator Author

lrknox commented Aug 19, 2021

merged to develop, hdf5_1_12, hdf5_1_10 and hdf5_1_8

lrknox added a commit that referenced this issue Aug 20, 2021
@lrknox
Fix issue #924, ${HDF5_CXXLINKER} does not work in h5c++. (#944)
5aa1582 
2 instances of CLINKER corrected to CXXLINKER
comment border aligned
@radistmorse radistmorse mentioned this issue Jul 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lrknox