Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable fortran warning #1014

Merged
merged 1 commit into from
Sep 16, 2021
Merged

Disable fortran warning #1014

merged 1 commit into from
Sep 16, 2021

Conversation

byrnHDF
Copy link
Contributor

@byrnHDF byrnHDF commented Sep 15, 2021

The -Wuse-without-only warning was the only warning in the gfort-5 file

@byrnHDF byrnHDF self-assigned this Sep 15, 2021
@lrknox lrknox requested a review from brtnfld September 15, 2021 20:47
lrknox pushed a commit that referenced this pull request Sep 16, 2021
@byrnHDF
Merge Disable fortran warning #1014 (#1016)
0322d16
brtnfld
brtnfld approved these changes Sep 16, 2021
View reviewed changes
Copy link
Collaborator

@brtnfld brtnfld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we not enabling warnings --enable-developer-warnings, doesn't this remove the warning entirely?

@byrnHDF
Copy link
Contributor Author

byrnHDF commented Sep 16, 2021

Are we not enabling warnings --enable-developer-warnings, doesn't this remove the warning entirely?

We could switch this to a dev warning file.

@brtnfld
Copy link
Collaborator

brtnfld commented Sep 16, 2021

Yes, that would be good.

@byrnHDF
Copy link
Contributor Author

byrnHDF commented Sep 16, 2021

Yes, that would be good.

Unfortunately there is NO fortran config support for developer flags. That will need to be a new issue!

@byrnHDF
Copy link
Contributor Author

byrnHDF commented Sep 16, 2021 •
edited
Loading

Created "Add Fortran developer flags to config" #1019 for the issue of adding Fortran developer flags as a build option.

@lrknox lrknox merged commit daeb445 into HDFGroup:develop Sep 16, 2021
lrknox pushed a commit that referenced this pull request Sep 17, 2021
@byrnHDF
Merge Disable fortran warning #1014 (#1015)
7afad40
@byrnHDF byrnHDF mentioned this pull request Sep 20, 2021
Merged
@byrnHDF byrnHDF deleted the develop-fort-warn branch September 30, 2021 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brtnfld brtnfld brtnfld approved these changes

@lrknox lrknox lrknox approved these changes

@derobins derobins Awaiting requested review from derobins derobins is a code owner

@qkoziol qkoziol Awaiting requested review from qkoziol qkoziol is a code owner

Assignees

@byrnHDF byrnHDF

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@byrnHDF @brtnfld @lrknox