Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to match clang and versions not just "Clang" #1029

Merged
merged 1 commit into from
Sep 22, 2021
Merged

Need to match clang and versions not just "Clang" #1029

merged 1 commit into from
Sep 22, 2021

Conversation

byrnHDF
Copy link
Contributor

@byrnHDF byrnHDF commented Sep 20, 2021

'strequal' is exact compare - 'matches' can compare substring

@byrnHDF byrnHDF self-assigned this Sep 20, 2021
@byrnHDF byrnHDF mentioned this pull request Sep 20, 2021
Merged
@lrknox lrknox merged commit 5344352 into HDFGroup:develop Sep 22, 2021
lrknox pushed a commit that referenced this pull request Sep 24, 2021
@byrnHDF
1.12 Merge Need to match clang and versions not just "Clang" #1029 (#…
0ea3bce 
…1030)

* Merge Need to match clang and versions not just "Clang"

* Merge MS clang needs EHsc flag #1035
lrknox pushed a commit that referenced this pull request Sep 24, 2021
@byrnHDF
1.10 Merge Need to match clang and versions not just "Clang" #1029 (#…
0d39445 
…1031)

* Merge Need to match clang and versions not just "Clang"

* Merge MS clang needs EHsc flag #1035
@byrnHDF byrnHDF deleted the develop-clang-check branch September 30, 2021 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derobins derobins derobins approved these changes

@lrknox lrknox lrknox approved these changes

@qkoziol qkoziol Awaiting requested review from qkoziol qkoziol is a code owner

Assignees

@byrnHDF byrnHDF

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@byrnHDF @derobins @lrknox