Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To reduce maintenance effort, delete the noerror- variants of the compiler flags files #1033

Merged
merged 5 commits into from
Oct 6, 2021

Commits on Sep 22, 2021

  1. Avoid maintenance headaches: delete the noerror- variants of the

    compiler flags files, since they essentially duplicate the `error-`
    files modulo the replacement of `-Werror=` with `-W` and any changes in
    comments.  (I verified the duplication with a script.)
    
    For autoconf, reinstate the use of the `demote_errors` shell function to
    derive the `noerror-` content from the `error-` content.  `demote_errors`
    replaces `-Werror=` with `-W` when `WARNINGS_AS_ERRORS` is `no`.
    
    Slightly reorder `configure.ac` so that the setting of
    `WARNINGS_AS_ERRORS` takes effect before the `error-` files are sourced.
    gnuoyd committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    faffd73 View commit details
    Browse the repository at this point in the history
  2. Take a stab at updating the CMake files to match the changes I made to

    the autoconf files to remove `noerror-` files.  I'm not much of a CMake
    user so these changes are quite rough.
    
    Looks like the duplication can be reduced with the introduction of a new
    macro.
    gnuoyd committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    30762f7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ae5af9d View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2021

  1. Reduce duplication in the CMake files: perform the

    HDF5_ENABLE_WARNINGS_AS_ERRORS test once in the ADD_H5_FLAGS macro.
    gnuoyd committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    99aeed4 View commit details
    Browse the repository at this point in the history
  2. Add a release note.

    gnuoyd committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    ead54fe View commit details
    Browse the repository at this point in the history