Implement parallel collective support for selection I/O. #1036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fortnern
requested review from
derobins,
brtnfld,
jhendersonHDF and
jrmainzer
fortnern
requested review from
qkoziol,
rawarren,
soumagne and
vchoi-hdfgroup
as code owners
|
Other than the need for a formatting run, no obvious issues. |
jrmainzer
approved these changes
Sep 24, 2021
src/H5Dcontig.c
Outdated
| @@ -658,7 +658,7 @@ H5D__contig_read(H5D_io_info_t *io_info, const H5D_type_info_t *type_info, hsize | |||
| /* Issue selection I/O call (we can skip the page buffer because we've | |||
| * already verified it won't be used, and the metadata accumulator | |||
| * because this is raw data) Only call funciton if nelmts > 0. */ | |||
There was a problem hiding this comment.
Does this header comment need updated in relation to now always calling the function below?
There was a problem hiding this comment.
Oops, thanks, I'll fix that when I run the formatter.
src/H5Dcontig.c
Outdated
| @@ -705,9 +705,9 @@ H5D__contig_write(H5D_io_info_t *io_info, const H5D_type_info_t *type_info, hsiz | |||
| /* Issue selection I/O call (we can skip the page buffer because we've | |||
| * already verified it won't be used, and the metadata accumulator | |||
| * because this is raw data). Only call funciton if nelmts > 0. */ | |||
There was a problem hiding this comment.
Same here about updating the comment?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.