Develop cmake install dir #1041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byrnHDF
requested review from
bmribler,
derobins,
lrknox and
qkoziol
as code owners
lrknox
approved these changes
Sep 28, 2021
bmribler
approved these changes
Sep 28, 2021
lrknox
pushed a commit
that referenced
this pull request
Sep 29, 2021
lrknox
pushed a commit
that referenced
this pull request
Sep 30, 2021
lrknox
pushed a commit
that referenced
this pull request
Oct 1, 2021
This was referenced Dec 21, 2021
Closed
ax3l
reviewed
Dec 21, 2021
| - Corrected path searched by CMake find_package command | ||
|
|
||
| The install path for cmake find_package files had been changed to use | ||
| "share/cmake" |
There was a problem hiding this comment.
@byrnHDF this causes a regression on at least Unix, since CMake config files are not in a supported path anymore.
The supported directory names are:
https://cmake.org/cmake/help/latest/command/find_package.html#config-mode-search-procedure
There was a problem hiding this comment.
For your tests, avoid setting HDF5_DIR to the CMake sub-path. Instead, just hint CMAKE_PREFIX_PATH to the root/prefix of the whole HDF5 installation. That's all that should be needed to hint a HDF5 install if the supported directory naming scheme is used :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrected path searched by CMake find_package command