Github #969 Use stdout instead of file for configure check #1089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byrnHDF
changed the title
byrnHDF
changed the title
lrknox
approved these changes
Oct 14, 2021
brtnfld
reviewed
Oct 28, 2021
| fi | ||
| rm -f pac_Cconftest.out | ||
| LDBL_DIG=$(./conftest$EXEEXT 2>&1 | sed -n '1p') | ||
| FLT128_DIG=$(./conftest$EXEEXT 2>&1 | sed -n '2p') |
There was a problem hiding this comment.
What if this fails? the error check was removed.
There was a problem hiding this comment.
Then the values will be empty.
There was a problem hiding this comment.
and it fails during build instead of in configure with probably an obscure error.
There was a problem hiding this comment.
The check in configure was only that the file existed and sed could read the file. It didn't check values.
We can add a configure-time check that the values are non-zero?
|
What is the reason for the change? Is there some JIRA issue this addresses? |
|
Github issue #969
From: Scot Breitenfeld ***@***.***>
Sent: Thursday, October 28, 2021 11:39 AM
To: HDFGroup/hdf5 ***@***.***>
Cc: Larry Knox ***@***.***>; Review requested ***@***.***>
Subject: Re: [HDFGroup/hdf5] Github #969 Use stdout instead of file for configure check (#1089)
What is the reason for the change? Is there some JIRA issue this addresses?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub<#1089 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADGMWCWVTPVM3JGBVU6BQNTUJF4BLANCNFSM5F557MPA>.
Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
|
HDF5 does not build on macOS Monterey with GCC 11.2 #1157 |
derobins
approved these changes
Nov 17, 2021
lrknox
pushed a commit
that referenced
this pull request
Nov 19, 2021
lrknox
pushed a commit
that referenced
this pull request
Nov 20, 2021
lrknox
pushed a commit
that referenced
this pull request
Nov 25, 2021
lrknox
pushed a commit
that referenced
this pull request
Dec 8, 2021
* Convert SWMR shell scripts to Windows powershell. * Use $LastExitCode instead of $? in script * Prevent execution in a different window * Github #969 Use stdout instead of file for configure check (#1089) * Use stdout instead of file for configure check * Make change requested by #1157 * Change fortran to use stderr for configure * Correct typo * remove obsolete file check * Fortran statement fix * Don't allow H5Pset(get)_all_coll_metadata_ops for DXPLs (#1201) * Fixes const warnings in H5ES package (#1211) * Quiets a 'set but not used' warning in h5diff_array.c (#1210) * Convert vds swmr test script to powershell * Enable vdsswmr powershell test * Add configure vdsswmr statement * Correct powershell script vars * Convert SWMR shell scripts to Windows powershell. * Use $LastExitCode instead of $? in script * Prevent execution in a different window * Github #969 Use stdout instead of file for configure check (#1089) * Use stdout instead of file for configure check * Make change requested by #1157 * Change fortran to use stderr for configure * Correct typo * remove obsolete file check * Fortran statement fix * Convert vds swmr test script to powershell * Enable vdsswmr powershell test * Add configure vdsswmr statement * Correct powershell script vars * Cleanup review issues * Fix variable assignment * Change the wait function to pass in the path * Disable actual test execution until programs fixed * Adjust copyright text * Fix spelling Co-authored-by: jhendersonHDF <jhenderson@hdfgroup.org> Co-authored-by: Dana Robinson <43805+derobins@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
github #969 requested that instead of writing config test info to a file that the info be pulled from stdout.
autoconf macro needs to use stderr.