OESS-168: Remove clang warnings. #1124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyoklee
requested review from
derobins,
fortnern,
jhendersonHDF,
jrmainzer,
qkoziol,
soumagne and
vchoi-hdfgroup
as code owners
derobins
reviewed
Oct 21, 2021
src/H5private.h
Outdated
| @@ -252,7 +252,7 @@ | |||
| #define H5_ATTR_NORETURN __attribute__((noreturn)) | |||
| #define H5_ATTR_CONST __attribute__((const)) | |||
| #define H5_ATTR_PURE __attribute__((pure)) | |||
| #if defined(__GNUC__) && __GNUC__ >= 7 && !defined(__INTEL_COMPILER) | |||
| #if defined(__clang__) || defined(__GNUC__) && __GNUC__ >= 7 && !defined(__INTEL_COMPILER) | |||
| #define H5_ATTR_FALLTHROUGH __attribute__((fallthrough)); | |||
| #else | |||
| #define H5_ATTR_FALLTHROUGH /*void*/ | |||
There was a problem hiding this comment.
Don't a lot of compilers respect a /* FALLTHROUGH */ comment? We might want to consider using that comment instead of /void/.
derobins
reviewed
Oct 21, 2021
| @@ -714,25 +714,35 @@ typedef unsigned char uint8_t; | |||
| hashv += (unsigned)(keylen); \ | |||
| switch (_hj_k) { \ | |||
| case 11: \ | |||
| hashv += ((unsigned)_hj_key[10] << 24); /* FALLTHROUGH */ \ | |||
| hashv += ((unsigned)_hj_key[10] << 24); \ | |||
| H5_ATTR_FALLTHROUGH \ | |||
There was a problem hiding this comment.
uthash is a file copied from an external repo. If it changes and we update it, we'll need to make sure these changes aren't lost.
derobins
approved these changes
Oct 21, 2021
|
All Github checks passed after clang-format changes committed. |
|
Please change this to use /* FALLTHROUGH / instead of / void */ before merging. It's a trivial change and will help some compilers. |
lrknox
approved these changes
Nov 5, 2021
hyoklee
added a commit
to hyoklee/hdf5
that referenced
this pull request
Nov 13, 2021
lrknox
pushed a commit
that referenced
this pull request
Nov 13, 2021
* TRILAB-266: Remove clang warnings in src/H5Zscaleoffset.c. (PR #1105) * Committing clang-format changes * TRILAB-266: Remove clang warnings in H5private.h and uthash.h. (PR #1124) * TRILAB-266: Remove clang warnings in H5FDcore.c. (PR #1127) * Committing clang-format changes * TRILAB-266: Remove clang warnings in test/testmeta.c. (PR #1135) * TRILAB-266: Remove clang warnings in test/swmr.c. (PR #1136) * TRILAB-266: Remove clang warnings in test/cork.c. (PR #1137) * Committing clang-format changes * TRILAB-266: Remove clang warnings in test/cork.c. (PR #1146) Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]from