OESS-168: Remove clang warnings. #1129
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyoklee
requested review from
derobins,
fortnern,
jhendersonHDF,
jrmainzer,
qkoziol,
soumagne and
vchoi-hdfgroup
as code owners
byrnHDF
approved these changes
Oct 22, 2021
gnuoyd
reviewed
Oct 22, 2021
| @@ -210,7 +210,7 @@ H5TEST_DLLVAR MPI_Info h5_io_info_g; /* MPI INFO object for IO */ | |||
| \ | |||
| ARR = (TYPE **)HDmalloc(h5taa_pointers_size + h5taa_data_size); \ | |||
| \ | |||
| ARR[0] = (TYPE *)(ARR + (DIMS_I)); \ | |||
| ARR[0] = (void *)(ARR + (DIMS_I)); \ | |||
There was a problem hiding this comment.
This is a place where the warning is easy to suppress but the alignment may still be wrong.
I believe DIMS_I and DIMS_J are constant. If so, then you can malloc a struct { TYPE *rows[DIMS_I]; TYPE values[DIMS_I * DIMS_J]; } *prototype;, initialize all DIMS_I pointers in rows, and then set ARR to &prototype->rows[0].
There was a problem hiding this comment.
As in #1130, I agree with Dave. Casting to a void pointer to make the compiler quiet is probably not the best fix here.
gnuoyd
added a commit
that referenced
this pull request
Nov 8, 2021
…OLS]; }`. This avoids the double-indirection through pointers and the additional memory of H5TEST_ALLOCATE_2D_ARRAY(). This change will safely quiet the cast warning that PR #1129 was intended to fix.
lrknox
pushed a commit
that referenced
this pull request
Nov 23, 2021
* Create 2D arrays on the heap by malloc'ing `struct { TYPE arr[ROWS][COLS];
}`. This avoids the double-indirection through pointers and the
additional memory of H5TEST_ALLOCATE_2D_ARRAY().
This change will safely quiet the cast warning that PR #1129 was
intended to fix.
* Committing clang-format changes
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
|
I believe #1169 fixed this? |
|
Fixed by #1169 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix the following warning:
h5dumpgentest.c:10258:5: warning: cast from 'long double **' to 'long double *' increases required alignment from 8 to 16 [-Wcast-align]