New references for Dimension Scale APIs #1139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w references should be used with Dimension Scales. The new function return TRUE if non-native connector is used or if H5_DIMENSION_SCALES_WITH_NEW_REF varible is define at configure time (--enable-dimension-scales-with-new-ref). Tested on jelly. ToDo: generate testing file on BE system and enable the test; add flag to CMake; test netCDF-4 with the new references.
… and 64-bit library. test_ds chokes on test_ds_le_new_ref.h5 on BE system; test passes for test_ds_be_new_ref-32bit.h5 for the 32-bit library and fails for the 64-bit library, and vice versa. I am checking the files for further investigation; but current implementation of the new references is not portable between LE and BE systems, and 32 and 64-bit systems.
Enabled broken test; tests pass now.
Documented new option to use new references with the HDF5 dimension scales APIs (H5DS*).
jhendersonHDF
requested review from
derobins,
soumagne,
brtnfld,
epourmal,
fortnern and
byrnHDF
jhendersonHDF
requested review from
bmribler,
jrmainzer,
lrknox,
qkoziol and
vchoi-hdfgroup
as code owners
byrnHDF
reviewed
Oct 25, 2021
byrnHDF
reviewed
Oct 25, 2021
byrnHDF
reviewed
Oct 25, 2021
jhendersonHDF
force-pushed
the
dimension_scales_new_refs
branch
from
9b63827
to
782d914
Compare
soumagne
approved these changes
Oct 29, 2021
| /*------------------------------------------------------------------------- | ||
| * Function: H5DSwith_new_ref | ||
| * | ||
| * Purpose: Detremines if new references are used with dimension scales. |
byrnHDF
approved these changes
Nov 5, 2021
lrknox
added a commit
that referenced
this pull request
Apr 2, 2022
* New references for Dimension Scale APIs (#1139) * Enable usage of new-style references with dimension scale APIs * Add API to check if an object ID represents a native connector object * Modified code to use new function H5DSwith_new_ref to determine if new references should be used with Dimension Scales. The new function return TRUE if non-native connector is used or if H5_DIMENSION_SCALES_WITH_NEW_REF varible is define at configure time (--enable-dimension-scales-with-new-ref). Tested on jelly. ToDo: generate testing file on BE system and enable the test; add flag to CMake; test netCDF-4 with the new references. * Adding new test files generated on BE system (hedgehog) created by 32 and 64-bit library. test_ds chokes on test_ds_le_new_ref.h5 on BE system; test passes for test_ds_be_new_ref-32bit.h5 for the 32-bit library and fails for the 64-bit library, and vice versa. I am checking the files for further investigation; but current implementation of the new references is not portable between LE and BE systems, and 32 and 64-bit systems. * Minor fixes for testing issues * Update test_ds.c Enabled broken test; tests pass now. * Update RELEASE.txt Documented new option to use new references with the HDF5 dimension scales APIs (H5DS*). * Update MANIFEST for new 32-bit new-style references test file for H5DS APIs * Update 'dimension scales w/ new-style refs' feature based on review Co-authored-by: Elena <epourmal@hdfgroup.org> * Fix H5DS warnings related to new H5DSwith_new_ref and H5VLobject_is_native APIs (#1184) Co-authored-by: jhendersonHDF <jhenderson@hdfgroup.org> Co-authored-by: Elena <epourmal@hdfgroup.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work by @epourmal to enable use of new-style references in the dimension scale APIs.