Quiets most const warnings in the fractal heap code #1188
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The biggest problem here is the 'generic operation' scheme that combines a const void pointer to arbitrary data + a callback that can sometimes modify said arbitrary data, thus undermining the const-ness in certain cases. Since nobody is going to rearchitect this scheme anytime soon, I've at least quieted the warnings that we know are not a problem since the "sometimes const" pointers won't be modified when they point to const data given the existing code.
In case anyone is wondering, making the operation callbacks simply take a non-const pointer is a bit like pulling on the loose yarn in a sweater. I started going down this road, but I think this is a more minimalist and cleaner solution for now.
I left the file pointer const warnings in the cache client code alone. That's a can of worms I'm unwilling to touch at this time and I also don't want to just glibly turn off the cast warnings.